diff options
| author | Eric Yilun Lin <yllin@chromium.org> | 2020-05-25 14:21:05 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-25 11:25:58 +0000 |
| commit | 436760fb09bfb7bc6c3f48c4b3c211285cb8977b (patch) | |
| tree | 2c608934f0b0ca20e6e6cbc8f4407940bdedc3a8 /board | |
| parent | 71bd6510b8a4e3867849a0984c3e73a7d67b8f9c (diff) | |
| download | chrome-ec-436760fb09bfb7bc6c3f48c4b3c211285cb8977b.tar.gz | |
kukui: pull up SPI1_NSS (CS_L).
There is no pull-up at AP side, so we should pull it up
at EC side to prevent EC SPI controller is starved waitting for
AP SPI commands.
BUG=b:156047546
TEST=make buildall; krane is booted.
BRANCH=kukui
Change-Id: I81f4aefb5e96f968cfbf5189b1f80e1e82f2d3ae
Signed-off-by: Eric Yilun Lin <yllin@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2214460
Reviewed-by: Ting Shen <phoenixshen@chromium.org>
Commit-Queue: Ting Shen <phoenixshen@chromium.org>
Diffstat (limited to 'board')
| -rw-r--r-- | board/damu/gpio.inc | 2 | ||||
| -rw-r--r-- | board/flapjack/gpio.inc | 2 | ||||
| -rw-r--r-- | board/jacuzzi/gpio.inc | 2 | ||||
| -rw-r--r-- | board/kakadu/gpio.inc | 2 | ||||
| -rw-r--r-- | board/kappa/gpio.inc | 2 | ||||
| -rw-r--r-- | board/kodama/gpio.inc | 2 | ||||
| -rw-r--r-- | board/kukui/gpio.inc | 2 |
7 files changed, 7 insertions, 7 deletions
diff --git a/board/damu/gpio.inc b/board/damu/gpio.inc index 85a1cfea4d..ba565b4772 100644 --- a/board/damu/gpio.inc +++ b/board/damu/gpio.inc @@ -25,7 +25,7 @@ GPIO_INT_RW(ACCEL_INT_ODL, PIN(A, 4), GPIO_INT_FALLING | GPIO_SEL_1P8V | GPIO_P bmi160_interrupt) GPIO_INT_RO(EMMC_CMD, PIN(B, 15), GPIO_INT_FALLING, emmc_cmd_interrupt) -GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH, +GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH | GPIO_PULL_UP, spi_event) /* SPI_AP_EC_CS_L */ GPIO_INT(LID_OPEN, PIN(C, 5), GPIO_INT_BOTH, lid_interrupt) diff --git a/board/flapjack/gpio.inc b/board/flapjack/gpio.inc index 7da5f53c6e..f349ceb972 100644 --- a/board/flapjack/gpio.inc +++ b/board/flapjack/gpio.inc @@ -38,7 +38,7 @@ GPIO_INT(CHARGER_INT_ODL, PIN(C, 13), GPIO_INT_FALLING | GPIO_PULL_UP, rt946x_interrupt) GPIO_INT_RO(EMMC_CMD, PIN(B, 15), GPIO_INT_FALLING, emmc_cmd_interrupt) -GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH, +GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH | GPIO_PULL_UP, spi_event) GPIO_INT_RW(SYNC_INT, PIN(A, 8), GPIO_INT_RISING | GPIO_PULL_DOWN, sync_interrupt) diff --git a/board/jacuzzi/gpio.inc b/board/jacuzzi/gpio.inc index 35e307d917..b0f5f25645 100644 --- a/board/jacuzzi/gpio.inc +++ b/board/jacuzzi/gpio.inc @@ -25,7 +25,7 @@ GPIO_INT_RW(ACCEL_INT_ODL, PIN(A, 4), GPIO_INT_FALLING | GPIO_SEL_1P8V | GPIO_P bmi160_interrupt) GPIO_INT_RO(EMMC_CMD, PIN(B, 15), GPIO_INT_FALLING, emmc_cmd_interrupt) -GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH, +GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH | GPIO_PULL_UP, spi_event) /* SPI_AP_EC_CS_L */ GPIO_INT(LID_OPEN, PIN(C, 5), GPIO_INT_BOTH, lid_interrupt) diff --git a/board/kakadu/gpio.inc b/board/kakadu/gpio.inc index 083529dfb7..308520ceda 100644 --- a/board/kakadu/gpio.inc +++ b/board/kakadu/gpio.inc @@ -35,7 +35,7 @@ GPIO_INT(CHARGER_INT_ODL, PIN(C, 13), GPIO_INT_FALLING | GPIO_PULL_UP, rt946x_interrupt) GPIO_INT_RO(EMMC_CMD, PIN(B, 15), GPIO_INT_FALLING, emmc_cmd_interrupt) -GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH, +GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH | GPIO_PULL_UP, spi_event) GPIO_INT_RW(SYNC_INT, PIN(A, 8), GPIO_INT_RISING | GPIO_PULL_DOWN, sync_interrupt) diff --git a/board/kappa/gpio.inc b/board/kappa/gpio.inc index 60cf796f46..1f3bd6cd9d 100644 --- a/board/kappa/gpio.inc +++ b/board/kappa/gpio.inc @@ -25,7 +25,7 @@ GPIO_INT_RW(ACCEL_INT_ODL, PIN(A, 4), GPIO_INT_FALLING | GPIO_SEL_1P8V | GPIO_P bmi160_interrupt) GPIO_INT_RO(EMMC_CMD, PIN(B, 15), GPIO_INT_FALLING, emmc_cmd_interrupt) -GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH, +GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH | GPIO_PULL_UP, spi_event) /* SPI_AP_EC_CS_L */ GPIO_INT(LID_OPEN, PIN(C, 5), GPIO_INT_BOTH, lid_interrupt) diff --git a/board/kodama/gpio.inc b/board/kodama/gpio.inc index b54d6f5ed5..75a3db7d20 100644 --- a/board/kodama/gpio.inc +++ b/board/kodama/gpio.inc @@ -35,7 +35,7 @@ GPIO_INT(CHARGER_INT_ODL, PIN(C, 13), GPIO_INT_FALLING | GPIO_PULL_UP, rt946x_interrupt) GPIO_INT_RO(EMMC_CMD, PIN(B, 15), GPIO_INT_FALLING, emmc_cmd_interrupt) -GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH, +GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH | GPIO_PULL_UP, spi_event) GPIO_INT_RW(SYNC_INT, PIN(A, 8), GPIO_INT_RISING | GPIO_PULL_DOWN, sync_interrupt) diff --git a/board/kukui/gpio.inc b/board/kukui/gpio.inc index e90644432b..1f17a24bcd 100644 --- a/board/kukui/gpio.inc +++ b/board/kukui/gpio.inc @@ -35,7 +35,7 @@ GPIO_INT(CHARGER_INT_ODL, PIN(C, 13), GPIO_INT_FALLING | GPIO_PULL_UP, rt946x_interrupt) GPIO_INT_RO(EMMC_CMD, PIN(B, 15), GPIO_INT_FALLING, emmc_cmd_interrupt) -GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH, +GPIO_INT(SPI1_NSS, PIN(A, 15), GPIO_INT_BOTH | GPIO_PULL_UP, spi_event) GPIO_INT_RW(SYNC_INT, PIN(A, 8), GPIO_INT_RISING | GPIO_PULL_DOWN, sync_interrupt) |