diff options
| author | Vadim Bendebury <vbendeb@chromium.org> | 2017-05-15 17:46:50 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-05-16 13:37:03 -0700 |
| commit | 7456475f99831bbeeca72c9c153e05b4558f832b (patch) | |
| tree | 3aeeeaafafbf9e2d71223a07f484acdc4741f9a6 /board | |
| parent | cb9bd66ec66ccd499ff597919806eafc1524acd2 (diff) | |
| download | chrome-ec-7456475f99831bbeeca72c9c153e05b4558f832b.tar.gz | |
cr50: drop obsolete/addressed TODOs
There many TODOs sprinkled in the code, some of them have been
addressed or do not apply any mode. This patch removes them.
BRANCH=cr50
BUG=none
TEST=built and ran cr50 on reef
Change-Id: Ica6edb204e5cc0cc9dc7f0d43fd39e7ddaf56809
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/506496
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'board')
| -rw-r--r-- | board/cr50/board.h | 12 | ||||
| -rw-r--r-- | board/cr50/tpm2/stubs.c | 1 | ||||
| -rw-r--r-- | board/cr50/wp.c | 7 |
3 files changed, 0 insertions, 20 deletions
diff --git a/board/cr50/board.h b/board/cr50/board.h index 601f9a7423..70e7a6f7ba 100644 --- a/board/cr50/board.h +++ b/board/cr50/board.h @@ -38,9 +38,7 @@ /* Flash configuration */ #undef CONFIG_FLASH_PSTATE -/* TODO(crosbug.com/p/44745): Bringup only! Do the right thing for real! */ #define CONFIG_WP_ALWAYS -/* TODO(crosbug.com/p/44745): For debugging only */ #define CONFIG_CMD_FLASH /* We're using TOP_A for partition 0, TOP_B for partition 1 */ @@ -213,9 +211,6 @@ int board_tpm_uses_spi(void); #define UARTN UART_CR50 -/* TODO(crosbug.com/p/56540): Remove this when UART0_RX works everywhere */ -#define GC_UART0_RX_DISABLE - #define CC_DEFAULT (CC_ALL & ~CC_MASK(CC_TPM)) /* Nv Memory users */ @@ -228,13 +223,6 @@ enum nvmem_users { #endif #define CONFIG_FLASH_NVMEM_VARS_USER_NUM NVMEM_CR50 - -/* - * Let's be on the lookout for stack overflow, while debugging. - * - * TODO(vbendeb): remove this before finalizing the code. - */ -#define CONFIG_DEBUG_STACK_OVERFLOW #define CONFIG_RW_B /* Firmware upgrade options. */ diff --git a/board/cr50/tpm2/stubs.c b/board/cr50/tpm2/stubs.c index d3e8710604..2d38b2c904 100644 --- a/board/cr50/tpm2/stubs.c +++ b/board/cr50/tpm2/stubs.c @@ -52,7 +52,6 @@ BOOL _cpri__Startup( /* * Below is the list of functions called by the TPM2 library from * _cpri__Startup(). - * TODO(vbendeb): verify proper initialization. * * _cpri__HashStartup() - not doing anything for now, maybe hw * reinitialization is required? diff --git a/board/cr50/wp.c b/board/cr50/wp.c index 63ca909c9b..84ca26d1a0 100644 --- a/board/cr50/wp.c +++ b/board/cr50/wp.c @@ -436,13 +436,6 @@ static int command_lock(int argc, char **argv) goto out; } - /* - * TODO(crosbug.com/p/55322, crosbug.com/p/55728): There may be - * other preconditions which must be satisified before - * continuing. We can return EC_ERROR_ACCESS_DENIED if those - * aren't met. - */ - /* Don't count down if we know it's likely to fail */ if (unlock_in_progress) { ccprintf("An unlock process is already in progress\n"); |