summaryrefslogtreecommitdiff
path: root/board
diff options
context:
space:
mode:
authorRuben Rodriguez Buchillon <coconutruben@chromium.org>2017-11-23 11:56:50 +0800
committerchrome-bot <chrome-bot@chromium.org>2017-11-23 04:39:15 -0800
commitbfa592f1673948469eca8f532da69462c4ecdbe6 (patch)
treef51ed453cdf99e834b99ea6c90a9677c06e3b681 /board
parent952189623d71852d4d4d438a4199592f8bcea034 (diff)
downloadchrome-ec-bfa592f1673948469eca8f532da69462c4ecdbe6.tar.gz
ec: reconfigure GPIO60 to be INPUT | PULL_UP for power savings
GPIO60 (PMIC_INT) is currently only configured for INPUT. Tests showed that INPUT | PULL_UP has lower power consumption so reconfiguring it here. BUG=b:64503543 BRANCH=none TEST=manual (on chroot) $ make BOARD=soraka -j $ ./util/flash_ec --board soraka (on DUT) $ powerd_dbus_suspend (on chroot) $ dut-control -p $PORT pp3300_dsw_ec_ma -t 10 | grep @@ > NAME COUNT AVERAGE STDDEV MAX MIN > pp3300_dsw_ec_ma 5637 1.68 0.17 7.92 1.56 for comparison, without the change, the MIN is 2.00mA Change-Id: I86407a1440765d040c39272480b185342597d52b Signed-off-by: Ruben Rodriguez Buchillon <coconutruben@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/786720 Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'board')
-rw-r--r--board/poppy/gpio.inc2
1 files changed, 1 insertions, 1 deletions
diff --git a/board/poppy/gpio.inc b/board/poppy/gpio.inc
index e040f64218..bda0029f8d 100644
--- a/board/poppy/gpio.inc
+++ b/board/poppy/gpio.inc
@@ -53,7 +53,7 @@ GPIO(BATTERY_PRESENT_L, PIN(3, 4), GPIO_INPUT) /* Battery Present */
GPIO(CCD_MODE_ODL, PIN(6, 3), GPIO_INPUT) /* Case Closed Debug Mode */
GPIO(EC_HAVEN_RESET_ODL, PIN(0, 2), GPIO_ODR_HIGH) /* H1 Reset */
GPIO(ENTERING_RW, PIN(7, 6), GPIO_OUTPUT) /* EC Entering RW */
-GPIO(PMIC_INT_L, PIN(6, 0), GPIO_INPUT) /* PMIC interrupt */
+GPIO(PMIC_INT_L, PIN(6, 0), GPIO_INPUT | GPIO_PULL_UP) /* PMIC interrupt */
#ifndef CONFIG_POWER_S0IX
GPIO(PCH_SLP_S0_L, PIN(7, 5), GPIO_INPUT)
#endif