diff options
| author | Namyoon Woo <namyoon@google.com> | 2020-05-06 14:27:47 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-14 04:03:17 +0000 |
| commit | 53f6d8a9334b259cf6ec3ddbc577ff49354c1ed1 (patch) | |
| tree | 0a353c42d490c0d0399a5297600b683a97ae85a3 /board | |
| parent | 7c2da5bce9c93041777c92711ff02d7672baa916 (diff) | |
| download | chrome-ec-53f6d8a9334b259cf6ec3ddbc577ff49354c1ed1.tar.gz | |
make cr50 agnostic about EC-EFS2
This patch makes cr50 respond EC-EFS2 related TPM commands no matter
it has the board property, BOARD_EC_CR50_COMM_SUPPORT or not.
board_has_ec_cr50_comm_support() calls remain for configuring
GPIO_EC_PACKET_MODE_EN only.
BUG=b:155214584
TEST=checked gsctool running on Coral.
[before]
$ gsctool --getbootmode
finding_device 18d1:5014
Found device.
found interface 3 endpoint 4, chunk_len 64
READY
-------
Error 8 in Getting boot mode
[after]
$ gsctool --getbootmode
finding_device 18d1:5014
Found device.
found interface 3 endpoint 4, chunk_len 64
READY
-------
Boot mode = 0x00: NORMAL
Also checked 'ec_comm' uart command.
[before]
> ec_comm
No EC-CR50 comm support
Invalid argument
Usage: ec_comm [corrupt]
[after]
> ec_comm
uart : 0xff
packet mode : DISABLED
phase : 0
preamble_count : 0
bytes_received : 0
bytes_expected : 0
response : 0x0000
ec_hash : UNLOADED <-- It is marked as unloaded,
secdata_error_code : 0x00001203 <-- because of NVMEM error.
boot_mode : NORMAL <-- Still, boot_mode is normal.
Signed-off-by: Namyoon Woo <namyoon@google.com>
Change-Id: I08dc9abd8f194c83484b5be9b0a5e8844b2fd221
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2185872
Tested-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Commit-Queue: Namyoon Woo <namyoon@chromium.org>
Diffstat (limited to 'board')
| -rw-r--r-- | board/cr50/board.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/board/cr50/board.c b/board/cr50/board.c index 8aa6dde87d..355c92ff97 100644 --- a/board/cr50/board.c +++ b/board/cr50/board.c @@ -1148,8 +1148,8 @@ void assert_ec_rst(void) /* Prevent bit bang interrupt storm. */ if (uart_bitbang_is_enabled()) task_disable_irq(bitbang_config.rx_irq); - else if (board_has_ec_cr50_comm_support()) - ec_efs_reset(); + + ec_efs_reset(); wait_ec_rst(1); |