diff options
| author | Ting Shen <phoenixshen@google.com> | 2020-09-03 18:52:37 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-09-07 09:06:05 +0000 |
| commit | 894bd7af49a8c12b48c7bfb953a7b4d1c1ceb32d (patch) | |
| tree | 3ba60cbd1083d154084272370e6ea62c88b80345 /board | |
| parent | de92f0bb311b7b5749aa7492ed6ac6b7d41b1671 (diff) | |
| download | chrome-ec-894bd7af49a8c12b48c7bfb953a7b4d1c1ceb32d.tar.gz | |
asurada: remove customized keyboard config
The keyboard config copied from Jacuzzi does not suitable for
Asurada for following two reasons:
- `output_settle_us` too short causes the scan timing of
column 2 and 3 overlapped.
- Jacuzzi adjusted the scan delay to reduce bitbang error rate.
Asurada does not need that.
The default config should be good enough for us.
BUG=b:167652253
TEST=press refresh key doesn't trigger 't'
BRANCH=none
Signed-off-by: Ting Shen <phoenixshen@google.com>
Change-Id: Ic2310bf1f9e37310d380da8d7efc26d1d0dbbd85
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2392074
Tested-by: Ting Shen <phoenixshen@chromium.org>
Auto-Submit: Ting Shen <phoenixshen@chromium.org>
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
Commit-Queue: Nicolas Boichat <drinkcat@chromium.org>
Diffstat (limited to 'board')
| -rw-r--r-- | board/asurada/board.c | 14 | ||||
| -rw-r--r-- | board/asurada/board.h | 1 |
2 files changed, 0 insertions, 15 deletions
diff --git a/board/asurada/board.c b/board/asurada/board.c index bf7508f0f1..828eb780df 100644 --- a/board/asurada/board.c +++ b/board/asurada/board.c @@ -238,20 +238,6 @@ static void board_sub_bc12_init(void) /* Must be done after I2C and subboard */ DECLARE_HOOK(HOOK_INIT, board_sub_bc12_init, HOOK_PRIO_INIT_I2C + 1); -/* Keyboard scan setting */ -struct keyboard_scan_config keyscan_config = { - .output_settle_us = 35, - .debounce_down_us = 5 * MSEC, - .debounce_up_us = 40 * MSEC, - .scan_period_us = 3 * MSEC, - .min_post_scan_delay_us = 1000, - .poll_timeout_us = 100 * MSEC, - .actual_key_mask = { - 0x14, 0xff, 0xff, 0xff, 0xff, 0xf5, 0xff, - 0xa4, 0xff, 0xfe, 0x55, 0xfa, 0xca /* full set */ - }, -}; - /* * I2C channels (A, B, and C) are using the same timing registers (00h~07h) * at default. diff --git a/board/asurada/board.h b/board/asurada/board.h index 33a197f69a..fd3d6b7fc0 100644 --- a/board/asurada/board.h +++ b/board/asurada/board.h @@ -64,7 +64,6 @@ /* Keyboard */ #define CONFIG_CMD_KEYBOARD -#define CONFIG_KEYBOARD_BOARD_CONFIG #define CONFIG_KEYBOARD_COL2_INVERTED #define CONFIG_KEYBOARD_PROTOCOL_MKBP #define CONFIG_MKBP_USE_GPIO |