summaryrefslogtreecommitdiff
path: root/board
diff options
context:
space:
mode:
authorMary Ruthven <mruthven@chromium.org>2021-10-07 11:23:07 -0500
committerCommit Bot <commit-bot@chromium.org>2021-10-13 16:55:32 +0000
commit39447a20c6e663d83b8581330378275530b3b2f3 (patch)
treeb9263a73374665b6a7e12957d345b257cb316c61 /board
parent39e75e0a99061689620de3df9adc81bc1d810f66 (diff)
downloadchrome-ec-39447a20c6e663d83b8581330378275530b3b2f3.tar.gz
rdd: only enable AP UART if the AP is on
When the AP is off, cr50 doesn't need to enable the AP UART. Having it enabled could cause power leakage if the signals aren't terminated correctly. Check ap_is_on and ap_uart_is_on before enabling the AP UART. BUG=b:136602563 TEST=firmware_Cr50DeviceState Change-Id: I192bdc4caef8cfa0ce6d8a3ca181b16388e35cd4 Signed-off-by: Mary Ruthven <mruthven@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3219756 Reviewed-by: Vadim Bendebury <vbendeb@chromium.org>
Diffstat (limited to 'board')
-rw-r--r--board/cr50/rdd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/board/cr50/rdd.c b/board/cr50/rdd.c
index 147596672b..0f6fcc6674 100644
--- a/board/cr50/rdd.c
+++ b/board/cr50/rdd.c
@@ -230,7 +230,7 @@ static void ccd_state_change_hook(void)
/* Start out by figuring what flags we might want enabled */
/* Enable AP UART RX if that device is on */
- if (ap_uart_is_on())
+ if (ap_uart_is_on() && ap_is_on())
flags_want |= CCD_ENABLE_UART_AP;
/*
* Enable EC UART RX.