cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.

We're never going to use this, let's just get rid of it.

BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware

Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.

Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

20 files changed, 26 insertions, 44 deletions

diff --git a/board/cr50/rdd.c b/board/cr50/rdd.c
index 608a025006..4d0fa942e8 100644
--- a/board/cr50/rdd.c
+++ b/board/cr50/rdd.c
@@ -160,6 +160,5 @@ static int command_ccd(int argc, char **argv)
 	return EC_SUCCESS;
 }
 DECLARE_CONSOLE_COMMAND(ccd, command_ccd,
-	"[uart] [<BOOLEAN>]",
-	"Get/set the case closed debug state",
-	NULL);
+			"[uart] [<BOOLEAN>]",
+			"Get/set the case closed debug state");
diff --git a/board/cr50/wp.c b/board/cr50/wp.c
index e32ce2189a..ecead90bb1 100644
--- a/board/cr50/wp.c
+++ b/board/cr50/wp.c
@@ -27,6 +27,5 @@ static int command_wp(int argc, char **argv)
 	return EC_SUCCESS;
 }
 DECLARE_CONSOLE_COMMAND(wp, command_wp,
-	"[bool]",
-	"Get/set the flash HW write-protect signal",
-	NULL);
+			"[<BOOLEAN>]",
+			"Get/set the flash HW write-protect signal");
diff --git a/board/elm/board.c b/board/elm/board.c
index de8142080f..a7562d9bb1 100644
--- a/board/elm/board.c
+++ b/board/elm/board.c
@@ -234,8 +234,7 @@ int command_pd_reset(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(resetpd, command_pd_reset,
 			"",
-			"Reset PD IC",
-			NULL);
+			"Reset PD IC");
 
 /**
  * There is a level shift for AC_OK & LID_OPEN signal between AP & EC,
diff --git a/board/glados/battery.c b/board/glados/battery.c
index 4c819dac48..2372affb64 100644
--- a/board/glados/battery.c
+++ b/board/glados/battery.c
@@ -225,7 +225,6 @@ static int command_fastcharge(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(fastcharge, command_fastcharge,
 			"[on|off]",
-			"Get or set fast charging profile",
-			NULL);
+			"Get or set fast charging profile");
 
 #endif	/* CONFIG_CHARGER_PROFILE_OVERRIDE */
diff --git a/board/glados_pd/board.c b/board/glados_pd/board.c
index 930f3eb66d..ba46c59b78 100644
--- a/board/glados_pd/board.c
+++ b/board/glados_pd/board.c
@@ -124,8 +124,7 @@ static int command_ec_int(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(ecint, command_ec_int,
 			"",
-			"Toggle EC interrupt line",
-			NULL);
+			"Toggle EC interrupt line");
 
 static int ec_status_host_cmd(struct host_cmd_handler_args *args)
 {
diff --git a/board/honeybuns/hx3.c b/board/honeybuns/hx3.c
index fe6de3c1f4..c5258632f3 100644
--- a/board/honeybuns/hx3.c
+++ b/board/honeybuns/hx3.c
@@ -139,5 +139,4 @@ static int command_hx3(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(hx3, command_hx3,
 			"",
-			"Reset and Send HX3 Hub settings over I2C",
-			NULL);
+			"Reset and Send HX3 Hub settings over I2C");
diff --git a/board/kevin/led_kevin.c b/board/kevin/led_kevin.c
index fbd80edbf1..21c1d0fe95 100644
--- a/board/kevin/led_kevin.c
+++ b/board/kevin/led_kevin.c
@@ -165,5 +165,4 @@ static int command_led_color(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(ledcolor, command_led_color,
 			"[debug|red|green|blue|off]",
-			"Change LED color",
-			NULL);
+			"Change LED color");
diff --git a/board/lucid/battery.c b/board/lucid/battery.c
index 7dc3872dff..d5d6a29dba 100644
--- a/board/lucid/battery.c
+++ b/board/lucid/battery.c
@@ -197,7 +197,6 @@ static int command_fastcharge(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(fastcharge, command_fastcharge,
 			"[on|off]",
-			"Get or set fast charging profile",
-			NULL);
+			"Get or set fast charging profile");
 
 #endif	/* CONFIG_CHARGER_PROFILE_OVERRIDE */
diff --git a/board/pdeval-stm32f072/usb_pd_policy.c b/board/pdeval-stm32f072/usb_pd_policy.c
index bf0445e316..73add50ca4 100644
--- a/board/pdeval-stm32f072/usb_pd_policy.c
+++ b/board/pdeval-stm32f072/usb_pd_policy.c
@@ -98,8 +98,7 @@ static int command_vbus_toggle(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(vbus, command_vbus_toggle,
 			"",
-			"Toggle VBUS detected",
-			NULL);
+			"Toggle VBUS detected");
 
 int pd_snk_is_vbus_provided(int port)
 {
diff --git a/board/plankton/board.c b/board/plankton/board.c
index 8f56422ba1..5bc6b776a3 100644
--- a/board/plankton/board.c
+++ b/board/plankton/board.c
@@ -586,8 +586,7 @@ static int cmd_usbc_action(int argc, char *argv[])
 }
 DECLARE_CONSOLE_COMMAND(usbc_action, cmd_usbc_action,
 			"<5v|12v|20v|ccd|dev|usb|dp|flip|pol0|pol1|drp>",
-			"Set Plankton type-C port state",
-			NULL);
+			"Set Plankton type-C port state");
 
 int board_in_hub_mode(void)
 {
@@ -628,7 +627,7 @@ static int cmd_usb_hub_reset(int argc, char *argv[])
 	return board_usb_hub_reset();
 }
 DECLARE_CONSOLE_COMMAND(hub_reset, cmd_usb_hub_reset,
-			NULL, "Reset USB hub", NULL);
+			NULL, "Reset USB hub");
 
 static void board_usb_hub_reset_no_return(void)
 {
@@ -771,7 +770,7 @@ static int cmd_fake_disconnect(int argc, char *argv[])
 	return EC_SUCCESS;
 }
 DECLARE_CONSOLE_COMMAND(fakedisconnect, cmd_fake_disconnect,
-			"<delay_ms> <duration_ms>", NULL, NULL);
+			"<delay_ms> <duration_ms>", NULL);
 
 static void trigger_dfu_release(void)
 {
@@ -789,4 +788,4 @@ static int cmd_trigger_dfu(int argc, char *argv[])
 	hook_call_deferred(&trigger_dfu_release_data, 1500 * MSEC);
 	return EC_SUCCESS;
 }
-DECLARE_CONSOLE_COMMAND(dfu, cmd_trigger_dfu, NULL, NULL, NULL);
+DECLARE_CONSOLE_COMMAND(dfu, cmd_trigger_dfu, NULL, NULL);
diff --git a/board/reef/battery.c b/board/reef/battery.c
index 850fc1a571..f0f7048296 100644
--- a/board/reef/battery.c
+++ b/board/reef/battery.c
@@ -295,7 +295,7 @@ static int command_fastcharge(int argc, char **argv)
 
 DECLARE_CONSOLE_COMMAND(fastcharge, command_fastcharge,
 			"[on|off]",
-			"Get or set fast charging profile", NULL);
+			"Get or set fast charging profile");
 
 #endif				/* CONFIG_CHARGER_PROFILE_OVERRIDE */
 
diff --git a/board/ryu/battery.c b/board/ryu/battery.c
index a7ecd3ea07..aab3f67291 100644
--- a/board/ryu/battery.c
+++ b/board/ryu/battery.c
@@ -219,8 +219,7 @@ static int command_fastcharge(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(fastcharge, command_fastcharge,
 			"[on|off]",
-			"Get or set fast charging profile",
-			NULL);
+			"Get or set fast charging profile");
 #endif  /* CONFIG_CMD_FASTCHARGE */
 
 #endif	/* CONFIG_CHARGER_PROFILE_OVERRIDE */
diff --git a/board/ryu/board.c b/board/ryu/board.c
index 0c570a4d2d..f860ba057b 100644
--- a/board/ryu/board.c
+++ b/board/ryu/board.c
@@ -744,5 +744,4 @@ static int cmd_btn_press(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(btnpress, cmd_btn_press,
 			"<volup|voldown> [0|1]",
-			"Simulate button press",
-			NULL);
+			"Simulate button press");
diff --git a/board/samus/battery.c b/board/samus/battery.c
index bd334d08c8..ad2c2723ea 100644
--- a/board/samus/battery.c
+++ b/board/samus/battery.c
@@ -220,8 +220,7 @@ static int command_fastcharge(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(fastcharge, command_fastcharge,
 			"[on|off]",
-			"Get or set fast charging profile",
-			NULL);
+			"Get or set fast charging profile");
 #endif  /* CONFIG_CMD_FASTCHARGE */
 
 #endif	/* CONFIG_CHARGER_PROFILE_OVERRIDE */
diff --git a/board/samus/extpower.c b/board/samus/extpower.c
index e54cb52a80..513bed48cd 100644
--- a/board/samus/extpower.c
+++ b/board/samus/extpower.c
@@ -435,5 +435,4 @@ static int command_backboost_det(int argc, char **argv)
 	return EC_SUCCESS;
 }
 DECLARE_CONSOLE_COMMAND(bkboost, command_backboost_det, NULL,
-			"Read backboost detection",
-			NULL);
+			"Read backboost detection");
diff --git a/board/samus_pd/board.c b/board/samus_pd/board.c
index de4a46729a..e535881c53 100644
--- a/board/samus_pd/board.c
+++ b/board/samus_pd/board.c
@@ -537,8 +537,7 @@ static int command_ec_int(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(ecint, command_ec_int,
 			"",
-			"Toggle EC interrupt line",
-			NULL);
+			"Toggle EC interrupt line");
 
 static int command_pd_host_event(int argc, char **argv)
 {
@@ -558,8 +557,7 @@ static int command_pd_host_event(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(pdevent, command_pd_host_event,
 			"event_mask",
-			"Send PD host event",
-			NULL);
+			"Send PD host event");
 
 /****************************************************************************/
 /* Host commands */
diff --git a/board/strago/led.c b/board/strago/led.c
index 3549e09c11..cb0c0c313f 100644
--- a/board/strago/led.c
+++ b/board/strago/led.c
@@ -202,6 +202,5 @@ static int command_led_color(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(ledcolor, command_led_color,
 			"[debug|red|green|amber|off]",
-			"Change LED color",
-			NULL);
+			"Change LED color");
 
diff --git a/board/twinkie/injector.c b/board/twinkie/injector.c
index 22031b9236..9b17180955 100644
--- a/board/twinkie/injector.c
+++ b/board/twinkie/injector.c
@@ -599,4 +599,4 @@ static int command_tw(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(twinkie, command_tw,
 			"[send|fsm|cc|resistor|txclock|rxthresh|vbus|vconn]",
-			"Manual Twinkie tweaking", NULL);
+			"Manual Twinkie tweaking");
diff --git a/board/twinkie/sniffer.c b/board/twinkie/sniffer.c
index 64e0060010..3c9f6fbd6a 100644
--- a/board/twinkie/sniffer.c
+++ b/board/twinkie/sniffer.c
@@ -549,4 +549,4 @@ static int command_sniffer(int argc, char **argv)
 	return EC_SUCCESS;
 }
 DECLARE_CONSOLE_COMMAND(sniffer, command_sniffer,
-			"[]", "Buffering status", NULL);
+			"[]", "Buffering status");
diff --git a/board/wheatley/battery.c b/board/wheatley/battery.c
index 4c819dac48..2372affb64 100644
--- a/board/wheatley/battery.c
+++ b/board/wheatley/battery.c
@@ -225,7 +225,6 @@ static int command_fastcharge(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(fastcharge, command_fastcharge,
 			"[on|off]",
-			"Get or set fast charging profile",
-			NULL);
+			"Get or set fast charging profile");
 
 #endif	/* CONFIG_CHARGER_PROFILE_OVERRIDE */