diff options
| author | Yuval Peress <peress@chromium.org> | 2019-07-15 11:40:47 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-08-23 00:25:33 +0000 |
| commit | a2e7b77b3b62d9f663eb1f916fe9ab36bef06dbe (patch) | |
| tree | 0508e2e77f23ba861090a53d1b99306fe9ad3046 /board | |
| parent | 3a2044d812f26a1ac0302a5eeb66eaf9433e78ba (diff) | |
| download | chrome-ec-a2e7b77b3b62d9f663eb1f916fe9ab36bef06dbe.tar.gz | |
common: Move fifo logic out of motion_sense.c
This change is needed to allow better testing of the fifo
behavior. Additionally, motion_sense_fifo.c will only be compiled
if CONFIG_ACCEL_FIFO is defined. This behaviour requires a few
small changes to several boards and baseboards to make
sure that we only define CONFIG_ACCEL_FIFO when the MOTIONSENSE
task is present (some times that may be only in one section RW or
RO).
BUG=b:137758297
BRANCH=None
TEST=buildall and ran CTS on arcada
Change-Id: I2f7e4e436ba9568a35b7a0b2c8d53a73f198ba73
Signed-off-by: Yuval Peress <peress@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1704163
Reviewed-by: Alexandru M Stan <amstan@chromium.org>
Commit-Queue: Alexandru M Stan <amstan@chromium.org>
Diffstat (limited to 'board')
| -rw-r--r-- | board/careena/board.h | 1 | ||||
| -rw-r--r-- | board/flapjack/board.h | 2 | ||||
| -rw-r--r-- | board/jacuzzi/board.h | 4 | ||||
| -rw-r--r-- | board/kodama/board.h | 4 | ||||
| -rw-r--r-- | board/kukui/board.c | 4 | ||||
| -rw-r--r-- | board/kukui/board.h | 4 | ||||
| -rw-r--r-- | board/liara/board.h | 1 |
7 files changed, 18 insertions, 2 deletions
diff --git a/board/careena/board.h b/board/careena/board.h index cfe0abd479..f8b225713a 100644 --- a/board/careena/board.h +++ b/board/careena/board.h @@ -9,6 +9,7 @@ #define __CROS_EC_BOARD_H #define VARIANT_GRUNT_TCPC_0_ANX3429 +#define VARIANT_GRUNT_NO_SENSORS #include "baseboard.h" diff --git a/board/flapjack/board.h b/board/flapjack/board.h index 15b52782b0..a7420a55eb 100644 --- a/board/flapjack/board.h +++ b/board/flapjack/board.h @@ -114,9 +114,11 @@ #define CONFIG_TABLET_MODE #define CONFIG_TABLET_MODE_SWITCH +#ifdef SECTION_IS_RW /* FIFO size is in power of 2. */ #define CONFIG_ACCEL_FIFO 256 #define CONFIG_ACCEL_FIFO_THRES (CONFIG_ACCEL_FIFO / 3) +#endif /* SECTION_IS_RW */ /* Wireless Power Charger Config */ #ifdef SECTION_IS_RW diff --git a/board/jacuzzi/board.h b/board/jacuzzi/board.h index bad56feb97..08a7974032 100644 --- a/board/jacuzzi/board.h +++ b/board/jacuzzi/board.h @@ -11,6 +11,10 @@ #define VARIANT_KUKUI_BATTERY_SMART #define VARIANT_KUKUI_CHARGER_ISL9238 +#ifndef SECTION_IS_RW +#define VARIANT_KUKUI_NO_SENSORS +#endif /* SECTION_IS_RW */ + #include "baseboard.h" /* TODO(b:135086465) led implementation */ diff --git a/board/kodama/board.h b/board/kodama/board.h index d865edefcd..44b1cae9ca 100644 --- a/board/kodama/board.h +++ b/board/kodama/board.h @@ -12,6 +12,10 @@ #define VARIANT_KUKUI_CHARGER_MT6370 #define VARIANT_KUKUI_DP_MUX_GPIO +#ifndef SECTION_IS_RW +#define VARIANT_KUKUI_NO_SENSORS +#endif /* SECTION_IS_RW */ + #include "baseboard.h" #define CONFIG_VOLUME_BUTTONS diff --git a/board/kukui/board.c b/board/kukui/board.c index 3d7b514a71..8f54d78f3b 100644 --- a/board/kukui/board.c +++ b/board/kukui/board.c @@ -306,7 +306,7 @@ DECLARE_HOOK(HOOK_INIT, board_rev_init, HOOK_PRIO_INIT_ADC + 1); /* Motion sensors */ /* Mutexes */ -#ifdef SECTION_IS_RW +#ifndef VARIANT_KUKUI_NO_SENSORS static struct mutex g_lid_mutex; static struct bmi160_drv_data_t g_bmi160_data; @@ -486,7 +486,7 @@ const unsigned int motion_sensor_count = ARRAY_SIZE(motion_sensors); const struct motion_sensor_t *motion_als_sensors[] = { &motion_sensors[CLEAR_ALS], }; -#endif /* SECTION_IS_RW */ +#endif /* VARIANT_KUKUI_NO_SENSORS */ void usb_charger_set_switches(int port, enum usb_switch setting) { diff --git a/board/kukui/board.h b/board/kukui/board.h index c017dc6c8c..4fd1a76a50 100644 --- a/board/kukui/board.h +++ b/board/kukui/board.h @@ -17,6 +17,10 @@ #define VARIANT_KUKUI_CHARGER_MT6370 #define VARIANT_KUKUI_DP_MUX_GPIO +#ifndef SECTION_IS_RW +#define VARIANT_KUKUI_NO_SENSORS +#endif /* SECTION_IS_RW */ + #include "baseboard.h" #define CONFIG_VOLUME_BUTTONS diff --git a/board/liara/board.h b/board/liara/board.h index e5260ee06e..b869f9f8c1 100644 --- a/board/liara/board.h +++ b/board/liara/board.h @@ -9,6 +9,7 @@ #define __CROS_EC_BOARD_H #define VARIANT_GRUNT_TCPC_0_ANX3429 +#define VARIANT_GRUNT_NO_SENSORS #include "baseboard.h" |