summaryrefslogtreecommitdiff
path: root/board
diff options
context:
space:
mode:
authorJett Rink <jettrink@chromium.org>2018-03-06 08:51:04 -0700
committerchrome-bot <chrome-bot@chromium.org>2018-03-07 16:55:19 -0800
commitf238375e1a7315bc7c713bf2989d19582daa1e95 (patch)
treeaea9b11e5545f1e600b7a9deeb9b5b79e31c1733 /board
parent2b1715b212c69bd5b9f1f88d06e7a027fa226b23 (diff)
downloadchrome-ec-f238375e1a7315bc7c713bf2989d19582daa1e95.tar.gz
npcx: remove optional CONFIG_PECI since no one is using it with npcx
Some boards have forgotten to undef CONFIG_PECI but it is benign. This should be an opt-in feature instead of an opt-out feature. No one is using it, so no one will opt-in. BRANCH=none BUG=none TEST=Verified that grunt, kahlee, meowth, and zoombini are not using the PECI bus for Soc temperature via schematics (GPIO81). Other boards are a no-op. See cl:951407 for steps taken to ensure all npcx boards were accounted for. Change-Id: I6ca4b9d22b7cb23c9842729658810ebe165ff6cc Signed-off-by: Jett Rink <jettrink@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/951408 Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Furquan Shaikh <furquan@chromium.org>
Diffstat (limited to 'board')
-rw-r--r--board/coral/board.h1
-rw-r--r--board/eve/board.h1
-rw-r--r--board/fizz/board.h1
-rw-r--r--board/glkrvp/board.h1
-rw-r--r--board/kevin/board.h1
-rw-r--r--board/nami/board.h1
-rw-r--r--board/nautilus/board.h1
-rw-r--r--board/npcx7_evb/board.h1
-rw-r--r--board/npcx_evb/board.h1
-rw-r--r--board/npcx_evb_arm/board.h1
-rw-r--r--board/poppy/board.h1
-rw-r--r--board/reef/board.h1
-rw-r--r--board/wheatley/board.h1
13 files changed, 1 insertions, 12 deletions
diff --git a/board/coral/board.h b/board/coral/board.h
index ce84d9caaf..092649341b 100644
--- a/board/coral/board.h
+++ b/board/coral/board.h
@@ -108,7 +108,6 @@
#define CONFIG_LPC
#define CONFIG_CHIPSET_APOLLOLAKE
#define CONFIG_CHIPSET_RESET_HOOK
-#undef CONFIG_PECI
#define CONFIG_POWER_BUTTON
#define CONFIG_POWER_BUTTON_X86
#define CONFIG_POWER_COMMON
diff --git a/board/eve/board.h b/board/eve/board.h
index bb72e4c3b4..e277aa92a2 100644
--- a/board/eve/board.h
+++ b/board/eve/board.h
@@ -74,7 +74,6 @@
#define CONFIG_KEYBOARD_PROTOCOL_8042
#define CONFIG_KEYBOARD_SCANCODE_MUTABLE
#define CONFIG_TABLET_MODE
-#undef CONFIG_PECI
/* Battery */
#define CONFIG_BATTERY_CUT_OFF
diff --git a/board/fizz/board.h b/board/fizz/board.h
index 63fd62b7b0..6e00fb092a 100644
--- a/board/fizz/board.h
+++ b/board/fizz/board.h
@@ -60,7 +60,6 @@
#define CONFIG_CHIPSET_SKYLAKE
#define CONFIG_CHIPSET_HAS_PLATFORM_PMIC_RESET
#define CONFIG_CHIPSET_RESET_HOOK
-#undef CONFIG_PECI
#define CONFIG_ESPI
/* Eve and Poppy all have wires from GPIO to PCH but CONFIG_ESPI_VW_SIGNALS
* is defined. So, those GPIOs are not used by EC. */
diff --git a/board/glkrvp/board.h b/board/glkrvp/board.h
index 0d8eaddcce..7025e92672 100644
--- a/board/glkrvp/board.h
+++ b/board/glkrvp/board.h
@@ -125,7 +125,6 @@
/* EC exclude modules */
#undef CONFIG_ADC
-#undef CONFIG_PECI
#undef CONFIG_WATCHDOG
#ifndef __ASSEMBLER__
diff --git a/board/kevin/board.h b/board/kevin/board.h
index f479fe7efb..89b14d1914 100644
--- a/board/kevin/board.h
+++ b/board/kevin/board.h
@@ -175,7 +175,6 @@
#define NPCX_SHI_BYPASS_OVER_256B
/* Optional for testing */
-#undef CONFIG_PECI
#undef CONFIG_PSTORE
/* Reduce code size */
diff --git a/board/nami/board.h b/board/nami/board.h
index c01f7db400..51139421b7 100644
--- a/board/nami/board.h
+++ b/board/nami/board.h
@@ -71,7 +71,6 @@
#define CONFIG_ESPI
#define CONFIG_ESPI_VW_SIGNALS
#define CONFIG_LPC
-#undef CONFIG_PECI
/* Battery */
#define CONFIG_BATTERY_CUT_OFF
diff --git a/board/nautilus/board.h b/board/nautilus/board.h
index cc9a86dc11..242bbc0524 100644
--- a/board/nautilus/board.h
+++ b/board/nautilus/board.h
@@ -63,7 +63,6 @@
#define CONFIG_ESPI
#define CONFIG_ESPI_VW_SIGNALS
#define CONFIG_LPC
-#undef CONFIG_PECI
/* Battery */
#define CONFIG_BATTERY_CUT_OFF
diff --git a/board/npcx7_evb/board.h b/board/npcx7_evb/board.h
index 4f9c5ecf61..4370cf5fbb 100644
--- a/board/npcx7_evb/board.h
+++ b/board/npcx7_evb/board.h
@@ -21,7 +21,6 @@
#define CONFIG_SPI
#define CONFIG_LPC
#define CONFIG_I2C
-#undef CONFIG_PECI
/* Features of eSPI */
#define CONFIG_ESPI /* Use eSPI protocol for host interface of x86 CPU */
#define CONFIG_ESPI_VW_SIGNALS /* Use VW signals instead of GPIOs */
diff --git a/board/npcx_evb/board.h b/board/npcx_evb/board.h
index f3eb270314..8c26e48e4c 100644
--- a/board/npcx_evb/board.h
+++ b/board/npcx_evb/board.h
@@ -13,6 +13,7 @@
#define CONFIG_PWM
#define CONFIG_SPI
#define CONFIG_LPC /* Used in Intel-based platform for host interface */
+#define CONFIG_PECI
/* Optional features */
#define CONFIG_SYSTEM_UNLOCKED /* Allow dangerous commands for testing */
diff --git a/board/npcx_evb_arm/board.h b/board/npcx_evb_arm/board.h
index dae3af8fb0..ee6a691e1c 100644
--- a/board/npcx_evb_arm/board.h
+++ b/board/npcx_evb_arm/board.h
@@ -49,7 +49,6 @@
#define NPCX_SHI_BYPASS_OVER_256B
/* Optional for testing */
-#undef CONFIG_PECI
#undef CONFIG_PSTORE
#undef CONFIG_LOW_POWER_IDLE /* Deep Sleep Support */
diff --git a/board/poppy/board.h b/board/poppy/board.h
index a092a1e870..ca4fa2c2b0 100644
--- a/board/poppy/board.h
+++ b/board/poppy/board.h
@@ -64,7 +64,6 @@
#define CONFIG_ESPI
#define CONFIG_ESPI_VW_SIGNALS
#define CONFIG_LPC
-#undef CONFIG_PECI
/* Battery */
#define CONFIG_BATTERY_CUT_OFF
diff --git a/board/reef/board.h b/board/reef/board.h
index 8f57420a8a..4693e17195 100644
--- a/board/reef/board.h
+++ b/board/reef/board.h
@@ -105,7 +105,6 @@
#define CONFIG_LPC
#define CONFIG_CHIPSET_APOLLOLAKE
#define CONFIG_CHIPSET_RESET_HOOK
-#undef CONFIG_PECI
#define CONFIG_POWER_BUTTON
#define CONFIG_POWER_BUTTON_X86
#define CONFIG_POWER_COMMON
diff --git a/board/wheatley/board.h b/board/wheatley/board.h
index ee58ef8de5..dcd773f827 100644
--- a/board/wheatley/board.h
+++ b/board/wheatley/board.h
@@ -139,7 +139,6 @@
#define OPT3001_I2C_ADDR OPT3001_I2C_ADDR1
/* Modules we want to exclude */
-#undef CONFIG_PECI
#undef CONFIG_CMD_HASH
#undef CONFIG_CMD_TEMP_SENSOR
#undef CONFIG_CMD_TIMERINFO