diff options
| author | Sam Hurst <shurst@google.com> | 2020-05-06 08:51:08 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-05-21 04:56:46 +0000 |
| commit | 61efe94f1e1ca1ebbd7c49ed9bd1bcfe8948e7f0 (patch) | |
| tree | d4484be2e69c78dcb8369be447b0b139ba147ef0 /board | |
| parent | c92f3d36f70a551e3df442cc7e015000f73f0578 (diff) | |
| download | chrome-ec-61efe94f1e1ca1ebbd7c49ed9bd1bcfe8948e7f0.tar.gz | |
TCPMv2: Only include PD3.0 functionality when CONFIG_USB_PD_REV30
The TCPMv2 stack defaults to PD2.0 functionality. Defining
CONFIG_USB_PD_REV30 enables PD3.0 functionality.
BUG=b:155879504
BRANCH=none
TEST=make -j buildall
Manual tests:
passed FAFT_PD running on kohaku
Before patch:
*** 18624 bytes in flash and 29216 bytes in RAM on kohaku RO ****
*** 18544 bytes in flash and 29216 bytes in RAM on kohaku RW ****
After patch:
*** 23320 bytes in flash and 30336 bytes in RAM on kohaku RO ****
*** 23228 bytes in flash and 30336 bytes in RAM on kohaku RW ****
Flash savings of 4696 bytest
Ram savings of 1120
Signed-off-by: Sam Hurst <shurst@google.com>
Change-Id: I082cf62617a91b487d2d3567afd5e340bd52258c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2184547
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'board')
| -rw-r--r-- | board/chocodile_vpdmcu/board.h | 1 | ||||
| -rw-r--r-- | board/mushu/board.h | 7 | ||||
| -rw-r--r-- | board/nocturne/board.h | 1 | ||||
| -rw-r--r-- | board/puff/board.h | 1 |
4 files changed, 8 insertions, 2 deletions
diff --git a/board/chocodile_vpdmcu/board.h b/board/chocodile_vpdmcu/board.h index 6a3c632773..09adee47b5 100644 --- a/board/chocodile_vpdmcu/board.h +++ b/board/chocodile_vpdmcu/board.h @@ -66,6 +66,7 @@ #define CONFIG_USB_PD_VBUS_DETECT_NONE #define CONFIG_USB_PD_TCPM_STUB #define CONFIG_USB_POWER_DELIVERY +#define CONFIG_USB_PD_REV30 #define CONFIG_USB_PD_TCPMV2 #define CONFIG_USB_CTVPD #define CONFIG_USB_PD_DECODE_SOP diff --git a/board/mushu/board.h b/board/mushu/board.h index 5629782fa8..d026ad598d 100644 --- a/board/mushu/board.h +++ b/board/mushu/board.h @@ -53,8 +53,11 @@ /* USB Type C and USB PD defines */ #undef CONFIG_USB_PD_TCPMV1 -#define CONFIG_USB_PD_TCPMV2 /* Use TCPMv2 */ -#define CONFIG_USB_PD_REV20 /* enable PD 2.0 because we have a parade TCPC */ +/* + * Enable TCPMv2. Use default PD 2.0 operation because we have a + * parade PS8751 TCPC + */ +#define CONFIG_USB_PD_TCPMV2 #define CONFIG_USB_PID 0x5047 #define CONFIG_USB_PD_DECODE_SOP #define CONFIG_USB_PD_TRY_SRC diff --git a/board/nocturne/board.h b/board/nocturne/board.h index 556f6dc009..2fb67c1cb2 100644 --- a/board/nocturne/board.h +++ b/board/nocturne/board.h @@ -141,6 +141,7 @@ #define CONFIG_USB_PD_LOGGING #define CONFIG_USB_PD_PORT_MAX_COUNT 2 #define CONFIG_USB_PD_TCPC_LOW_POWER +#define CONFIG_USB_PD_REV30 #define CONFIG_USB_PD_TCPMV2 #define CONFIG_USB_PD_TCPM_MUX #define CONFIG_USB_PD_TCPM_PS8805 diff --git a/board/puff/board.h b/board/puff/board.h index 9c6314819d..179e45e7bb 100644 --- a/board/puff/board.h +++ b/board/puff/board.h @@ -130,6 +130,7 @@ /* USB type C */ #define CONFIG_USB_PD_TCPMV2 /* Use TCPMv2 */ +#define CONFIG_USB_PD_REV30 /* Enable PD 3.0 functionality */ #define CONFIG_USB_PD_DECODE_SOP #undef CONFIG_USB_CHARGER #define CONFIG_USB_POWER_DELIVERY |