diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2016-10-26 19:08:42 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-10-27 01:21:54 -0700 |
| commit | 5b556dbd24b3a8f671f023cede096016963a843c (patch) | |
| tree | 3076012e1630bbedc1e568c925311adc9ad137e8 /board | |
| parent | 3337c17efd8e0be713676954faa24401d3b5bb3b (diff) | |
| download | chrome-ec-5b556dbd24b3a8f671f023cede096016963a843c.tar.gz | |
kevin: Add bugs to TODOs.
Found some TODOs and filed bugs for them.
BUG=None
BRANCH=gru
TEST=make -j buildall
Change-Id: I3aa4350383f1fe9954f2dd20811c2256d0940a48
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/404112
Commit-Ready: Aseda Aboagye <aaboagye@chromium.org>
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Philip Chen <philipchen@chromium.org>
Diffstat (limited to 'board')
| -rw-r--r-- | board/kevin/board.h | 5 | ||||
| -rw-r--r-- | board/kevin/usb_pd_policy.c | 2 |
2 files changed, 5 insertions, 2 deletions
diff --git a/board/kevin/board.h b/board/kevin/board.h index 9f34fe110c..15d97dbc97 100644 --- a/board/kevin/board.h +++ b/board/kevin/board.h @@ -130,7 +130,10 @@ #define PD_MAX_CURRENT_MA 3000 #define PD_MAX_VOLTAGE_MV 20000 -/* TODO: determine the following board specific type-C power constants */ +/* + * TODO(crosbug.com/p/59074): determine the following board specific type-C + * power constants + */ #define PD_POWER_SUPPLY_TURN_ON_DELAY 30000 /* us */ #define PD_POWER_SUPPLY_TURN_OFF_DELAY 50000 /* us */ #define PD_VCONN_SWAP_DELAY 5000 /* us */ diff --git a/board/kevin/usb_pd_policy.c b/board/kevin/usb_pd_policy.c index a880b1375f..44cd120448 100644 --- a/board/kevin/usb_pd_policy.c +++ b/board/kevin/usb_pd_policy.c @@ -25,7 +25,7 @@ #define PDO_FIXED_FLAGS (PDO_FIXED_DUAL_ROLE | PDO_FIXED_DATA_SWAP |\ PDO_FIXED_COMM_CAP) -/* TODO: fill in correct source and sink capabilities */ +/* TODO(crosbug.com/p/59075): fill in correct source and sink capabilities */ const uint32_t pd_src_pdo[] = { PDO_FIXED(5000, 1500, PDO_FIXED_FLAGS), }; |