diff options
| author | Vadim Bendebury <vbendeb@google.com> | 2017-08-02 11:35:25 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-08-02 17:26:42 -0700 |
| commit | 5a9d0de240fd7e964f15e7f2cae33277fd57f046 (patch) | |
| tree | fe364780f1597fe677bd0f08f22b870828c6f843 /chip/g/build.mk | |
| parent | e156e014dda43438761985cf67ca95ec48cb3208 (diff) | |
| download | chrome-ec-5a9d0de240fd7e964f15e7f2cae33277fd57f046.tar.gz | |
g: stop converting hex device id values to ints
The new signer (version: 1.2 00840c1b6) allows hex values in the
manifest, which means there is no need to explicitly convert the
values before adding them to the manifest.
A nice side effect of this is the fact that there is no need to care
about the sign of the values any more, the signer does the right
thing.
BRANCH=none
BUG=none
TEST=built an image using the following invocation:
$ make BOARD=cr50 H1_DEVIDS='0x12009015 0x90e95664' -j
and successfully ran it on a device. Note that the old signer was
chocking on hex values exceeding 0x7fffffff, the new one handles
them properly.
Change-Id: I08c0339f922d287c82d56fb51570bfbf7107531e
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/598728
Reviewed-by: Nick Sanders <nsanders@chromium.org>
Diffstat (limited to 'chip/g/build.mk')
| -rw-r--r-- | chip/g/build.mk | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chip/g/build.mk b/chip/g/build.mk index c13cccecad..136235b24a 100644 --- a/chip/g/build.mk +++ b/chip/g/build.mk @@ -171,7 +171,7 @@ else DUMMY := $(shell /bin/cp $(MANIFEST) $(SIGNER_MANIFEST)) endif REPLACEMENT := $(shell printf \ - '\\n \\"DEV_ID0\\": %d,\\n \\"DEV_ID1\\": %d,' $(H1_DEVIDS)) + '\\n \\"DEV_ID0\\": %s,\\n \\"DEV_ID1\\": %s,' $(H1_DEVIDS)) NODE_JSON := $(shell sed -i \ "s/\"fuses\": {/\"fuses\": {$(REPLACEMENT)/" $(SIGNER_MANIFEST)) |