diff options
| author | Louis Collard <louiscollard@chromium.org> | 2018-12-06 09:34:29 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-12-06 22:06:35 -0800 |
| commit | 82452ec24849203303037231e8012738fd8ccf7f (patch) | |
| tree | 3b8c66ffa6c51ff07a9f6be864559686ce047b74 /chip/g/sn_bits.c | |
| parent | de2442d5ea70c5fd70a1ebec86d6d23146fb92a6 (diff) | |
| download | chrome-ec-82452ec24849203303037231e8012738fd8ccf7f.tar.gz | |
cr50: Fix return value for VENDOR_CC_SN_SET_HASH.
I made a careless mistake when incorporating comments during
review of CL:1237696 and broke the return value for this
vendor command. The command still sets SN bits correctly, but
in most cases (success and failure), returns VENDOR_RC_NOT_ALLOWED.
BUG=b:111195266
TEST=tested locally on soraka
BRANCH=none
Change-Id: I6d3bc1c9df7737f7469c6f432da2e65c79f324a6
Signed-off-by: Louis Collard <louiscollard@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1364490
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Andrey Pronin <apronin@chromium.org>
Diffstat (limited to 'chip/g/sn_bits.c')
| -rw-r--r-- | chip/g/sn_bits.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/chip/g/sn_bits.c b/chip/g/sn_bits.c index e56aa7408f..0057d26299 100644 --- a/chip/g/sn_bits.c +++ b/chip/g/sn_bits.c @@ -170,7 +170,7 @@ static enum vendor_cmd_rc vc_sn_set_hash(enum vendor_cmd_cc code, if (read_board_id(&bid) != EC_SUCCESS || ~(bid.type & bid.type_inv & bid.flags) != 0) { *pbuf = EC_ERROR_ACCESS_DENIED; - return *pbuf; + return VENDOR_RC_NOT_ALLOWED; } memcpy(&sn_hash, pbuf, sizeof(sn_hash)); @@ -178,7 +178,7 @@ static enum vendor_cmd_rc vc_sn_set_hash(enum vendor_cmd_cc code, /* We care about the LSB only. */ *pbuf = (uint8_t) write_sn_hash(sn_hash); - return VENDOR_RC_NOT_ALLOWED; + return *pbuf; } DECLARE_VENDOR_COMMAND(VENDOR_CC_SN_SET_HASH, vc_sn_set_hash); |