diff options
| author | Namyoon Woo <namyoon@chromium.org> | 2020-01-21 14:59:09 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-01-22 20:55:27 +0000 |
| commit | 88549e6d2bf0f951d58b9a714033a08a72372df3 (patch) | |
| tree | 624f52fce332b944ad963f316cd3766d8724c433 /chip/g/uartn.h | |
| parent | 29dcf53164fa4b003414ab666b81286f4fbdf058 (diff) | |
| download | chrome-ec-88549e6d2bf0f951d58b9a714033a08a72372df3.tar.gz | |
revise the uart tx connect/disconnect functionsstabilize-quickfix-12871.27.B-cr50_stabstabilize-12871.91.B-cr50_stabstabilize-12871.65.B-cr50_stabstabilize-12871.57.B-cr50_stabstabilize-12871.253.B-cr50_stabstabilize-12871.24.B-cr50_stabstabilize-12871.103.B-cr50_stabstabilize-12871.102.B-cr50_stabstabilize-12859.B-cr50_stabrelease-R81-12871.B-cr50_stab
This patch reduces redundant condition checking in connecting
or disconnecting UART TX.
BUG=none
BRANCH=cr50
TEST=manually checked ccd state with/without servo connection and/or
ccd connection.
[AFTER]
> ccdstate
AP: on
AP UART: on
EC: on
Rdd: connected
Servo: connected
CCD EXT: enabled
State flags: UARTAP UARTEC
CCD ports blocked: (none)
> ccdstate
AP: on
AP UART: on
EC: on
Rdd: disconnected
Servo: connected
CCD EXT: disabled
State flags:
CCD ports blocked: (none)
> ccdstate
AP: on
AP UART: on
EC: on
Rdd: connected
Servo: undetectable
CCD EXT: enabled
State flags: UARTAP+TX UARTEC+TX I2C SPI
CCD ports blocked: (none)
> ccdstate
AP: off
AP UART: off
EC: on
Rdd: connected
Servo: undetectable
CCD EXT: enabled
State flags: UARTEC+TX I2C SPI
CCD ports blocked: (none)
> ccdstate
AP: on
AP UART: on
EC: on
Rdd: connected
Servo: disconnected
CCD EXT: enabled
State flags: UARTAP+TX I2C SPI
CCD ports blocked: EC
> ccdstate
AP: on
AP UART: on
EC: on
Rdd: connected
Servo: disconnected
CCD EXT: enabled
State flags: I2C SPI
CCD ports blocked: AP EC
> ccdstate
AP: on
AP UART: on
EC: on
Rdd: connected
Servo: ignored
CCD EXT: enabled
State flags: UARTAP+TX UARTEC+TX I2C SPI
CCD ports blocked: IGNORE_SERVO
WARNING: enabling UART while servo is connected may damage hardware
Change-Id: Icea2978b15e15bbf7cea8e48fd2bf4fdecc78f46
Signed-off-by: Namyoon Woo <namyoon@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2013823
Reviewed-by: Mary Ruthven <mruthven@chromium.org>
Diffstat (limited to 'chip/g/uartn.h')
| -rw-r--r-- | chip/g/uartn.h | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/chip/g/uartn.h b/chip/g/uartn.h index bfb7772518..e0d0c140b3 100644 --- a/chip/g/uartn.h +++ b/chip/g/uartn.h @@ -82,12 +82,6 @@ void uartn_tx_stop(int uart); */ int uart_tx_is_connected(int uart); -/* Connect TX pin for the UART */ -void uartn_tx_connect(int uart); - -/* Disconnect TX pin for the UART */ -void uartn_tx_disconnect(int uart); - /** * Return non-zero if TX and RX are enabled for the UART. * |