diff options
author | Yuval Peress <peress@chromium.org> | 2021-08-04 11:19:55 -0600 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2021-08-20 14:32:44 +0000 |
commit | 8270698e589f14239b4942a42b27132af497410b (patch) | |
tree | ea10c53f412c229980ea24a6faf8572295b92f75 /chip/host/system.c | |
parent | d63ba9739b77bece9e0be136dd256c89ce2fd688 (diff) | |
download | chrome-ec-8270698e589f14239b4942a42b27132af497410b.tar.gz |
system: fix system_get_scratchpad API
The current API for system_get_scratchpad mixes the status and the value
being read. Update the signature to allow both.
BRANCH=none
BUG=b:195481980
TEST=make testall && zmake testall
Signed-off-by: Yuval Peress <peress@chromium.org>
Change-Id: I3a5f5ad523d507c53a5d474806f58afafb82e70c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3074828
Commit-Queue: Denis Brockus <dbrockus@chromium.org>
Reviewed-by: Denis Brockus <dbrockus@chromium.org>
Diffstat (limited to 'chip/host/system.c')
-rw-r--r-- | chip/host/system.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/chip/host/system.c b/chip/host/system.c index b685d86a7d..60d765deab 100644 --- a/chip/host/system.c +++ b/chip/host/system.c @@ -225,22 +225,21 @@ int system_set_scratchpad(uint32_t value) return EC_SUCCESS; } -uint32_t system_get_scratchpad(void) +int system_get_scratchpad(uint32_t *value) { FILE *f = get_persistent_storage("scratchpad", "r"); - uint32_t value; int success; if (f == NULL) - return 0; + return EC_ERROR_UNKNOWN; - success = fscanf(f, "%u", &value); + success = fscanf(f, "%u", value); release_persistent_storage(f); if (success) - return value; + return EC_SUCCESS; else - return 0; + return EC_ERROR_UNKNOWN; } static void __jump_resetvec(void) |