diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 15:57:52 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:55 -0700 |
| commit | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (patch) | |
| tree | f6ada087f62246c3a9547e649ac8846b0ed6d5ab /chip/ish/ish_i2c.h | |
| parent | 0bfc511527cf2aebfa163c63a1d028419ca0b0c3 (diff) | |
| download | chrome-ec-bb266fc26fc05d4ab22de6ad7bce5b477c9f9140.tar.gz | |
common: replace 1 << digits, with BIT(digits)
Requested for linux integration, use BIT instead of 1 <<
First step replace bit operation with operand containing only digits.
Fix an error in motion_lid try to set bit 31 of a signed integer.
BUG=None
BRANCH=None
TEST=compile
Change-Id: Ie843611f2f68e241f0f40d4067f7ade726951d29
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518659
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'chip/ish/ish_i2c.h')
| -rw-r--r-- | chip/ish/ish_i2c.h | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/chip/ish/ish_i2c.h b/chip/ish/ish_i2c.h index d981b545ae..2b88524fda 100644 --- a/chip/ish/ish_i2c.h +++ b/chip/ish/ish_i2c.h @@ -154,11 +154,11 @@ enum { TX_BUFFER_DEPTH_OFFSET = 16, RX_BUFFER_DEPTH_OFFSET = 8, /* IC_INTR_MASK VALUES */ - M_RX_FULL = (1 << 2), - M_TX_EMPTY = (1 << 4), - M_TX_ABRT = (1 << 6), - M_STOP_DET = (1 << 9), - M_START_DET = (1 << 10), + M_RX_FULL = BIT(2), + M_TX_EMPTY = BIT(4), + M_TX_ABRT = BIT(6), + M_STOP_DET = BIT(9), + M_START_DET = BIT(10), IC_INTR_WRITE_MASK_VAL = (M_STOP_DET | M_TX_ABRT), IC_INTR_READ_MASK_VAL = (M_RX_FULL | M_TX_ABRT), DISABLE_INT = 0, |