diff options
| author | Denis Brockus <dbrockus@chromium.org> | 2019-06-18 10:24:34 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-06-18 21:23:07 +0000 |
| commit | 47253f9f4b3968c3bd8e1a731e730fe2aab614c6 (patch) | |
| tree | 825b095fe7b46aafdd0203e598c1fcbf076c209f /chip/ish/registers.h | |
| parent | efbdc0df890dc45ef7baddc85a1649e9dd2983d8 (diff) | |
| download | chrome-ec-47253f9f4b3968c3bd8e1a731e730fe2aab614c6.tar.gz | |
ish: snowball linker cleanup
Change AON_ROM references to be AON_PERSISTENT, these are not readonly
Use the linker to set a snowball structure in the right place so we do
not have to maintain hardcoded addresses in the register file
BUG=b:132690500
BRANCH=none
TEST=make buildall -j and check map location of snowball to be correct
Change-Id: I4983a078fbd067b9c7ec9f0c49f962a4cb1581b7
Signed-off-by: Denis Brockus <dbrockus@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1664593
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Diffstat (limited to 'chip/ish/registers.h')
| -rw-r--r-- | chip/ish/registers.h | 17 |
1 files changed, 0 insertions, 17 deletions
diff --git a/chip/ish/registers.h b/chip/ish/registers.h index 42ccb44106..8f989fc647 100644 --- a/chip/ish/registers.h +++ b/chip/ish/registers.h @@ -331,21 +331,4 @@ enum ish_i2c_port { #define ISH_SRAM_CTRL_ERASE_ADDR REG32(ISH_SRAM_CTRL_BASE + 0x10) #define ISH_SRAM_CTRL_BANK_STATUS REG32(ISH_SRAM_CTRL_BASE + 0x2c) -#if defined(CHIP_FAMILY_ISH3) -/* on ISH3, reused ISH2PMC IPC message registers */ -#define SNOWBALL_BASE IPC_ISH2PMC_MSG_BASE -#else -/* from ISH4, used reserved rom part of AON memory */ -#define SNOWBALL_BASE (CONFIG_AON_ROM_BASE + 256) -#endif - -/** - * registers about UMA/IMR DDR information and FW location in it - * ISH Bringup will set these registers' value at boot - */ -#define SNOWBALL_UMA_BASE_HI REG32(SNOWBALL_BASE + (4 * 28)) -#define SNOWBALL_UMA_BASE_LO REG32(SNOWBALL_BASE + (4 * 29)) -#define SNOWBALL_UMA_LIMIT REG32(SNOWBALL_BASE + (4 * 30)) -#define SNOWBALL_FW_OFFSET REG32(SNOWBALL_BASE + (4 * 31)) - #endif /* __CROS_EC_REGISTERS_H */ |