diff options
| author | Dino Li <Dino.Li@ite.com.tw> | 2019-10-03 12:00:17 +0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-10-17 06:20:06 +0000 |
| commit | 37edd51bc1465a873ede878978556542b8fe3c20 (patch) | |
| tree | 553eca5310533915128ee936b52f941ef5f93a85 /chip/it83xx/clock.c | |
| parent | 9e271aeb78c7f8bc21cd52b66305217d0770ac46 (diff) | |
| download | chrome-ec-37edd51bc1465a873ede878978556542b8fe3c20.tar.gz | |
chip/it83xx: introduction of IT83202/BX version
- Changing PLL and standby instruction didn't work on AX have been
fixed on this version, so we can remove patches dedicated for AX.
- Enable more chip config option.
- Disable IT83XX_INTC_GROUP_21_22_SUPPORT option:
Because IT8xxx2 series has its own interrupt group 21 and 22,
so we will create another CL to support them.
- System triggers a soft reset by default if IT83XX_ETWD_HW_RESET_SUPPORT
option is enabled.
BUG=b:134542199; b:133460224; b:142029177
BRANCH=none
TEST=boots on BX version.
console command reboot:
reboot hard
Hard-Rebooting!
[Reset cause: power-on hard]
reboot
Rebooting!
[Reset cause: soft]
Change-Id: I06e57952cd758b4f344ada0f87729c961b1e747b
Signed-off-by: Dino Li <Dino.Li@ite.com.tw>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1835884
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'chip/it83xx/clock.c')
| -rw-r--r-- | chip/it83xx/clock.c | 14 |
1 files changed, 4 insertions, 10 deletions
diff --git a/chip/it83xx/clock.c b/chip/it83xx/clock.c index b3771adcb5..468037f0e9 100644 --- a/chip/it83xx/clock.c +++ b/chip/it83xx/clock.c @@ -193,10 +193,6 @@ static void clock_set_pll(enum pll_freq_idx idx) { int pll; - /* TODO(b/134542199): fix me... Changing PLL failed on it83202/ax */ - if (IS_ENABLED(CHIP_VARIANT_IT83202AX)) - return; - pll_div_fnd = clock_pll_ctrl[idx].div_fnd; pll_div_ec = clock_pll_ctrl[idx].div_ec; pll_div_jtag = clock_pll_ctrl[idx].div_jtag; @@ -425,13 +421,11 @@ void clock_cpu_standby(void) asm("standby wake_grant"); } else if (IS_ENABLED(CHIP_CORE_RISCV)) { /* - * An interrupt is not able to wake EC up from low power mode. - * (AX bug) + * TODO(b:142029177): we have to enable interrupts before + * standby instruction on IT8xxx2 series. */ - if (IS_ENABLED(CHIP_VARIANT_IT83202AX)) - asm("nop"); - else - asm("wfi"); + interrupt_enable(); + asm("wfi"); } } |