diff options
| author | Furquan Shaikh <furquan@chromium.org> | 2017-10-30 18:30:03 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2017-10-31 13:04:58 -0700 |
| commit | 7d66541b462a5b86ab051ce1a4ad5404496a991c (patch) | |
| tree | 41fc8f797a916fb49bc29a6b7e5038c0a2ea3b6c /chip/it83xx/lpc.c | |
| parent | 7b8fb2ad2a60f70bad675b66c8dbe68fcb344629 (diff) | |
| download | chrome-ec-7d66541b462a5b86ab051ce1a4ad5404496a991c.tar.gz | |
lpc: Add and use lpc_resume_clear_masks
Add a new LPC helper routine lpc_resume_clear_masks that can be used
to clear SCI, SMI and wake masks upon resume from S3. This is done to
mask the events until host explicitly unmasks them.
It also ensures that these masks do not get reset on resume from S0ix
where the host does not re-configure these masks.
BUG=b:68669668
BRANCH=None
TEST=Verified following:
1. make -j buildall
2. On resume from S0ix, SCI mask is not reset.
3. On resume from S3, SCI mask is reset and then set again by host request.
Change-Id: I17a86bd60ef066b3716fb79ecce62f311eb45509
Signed-off-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/745533
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Diffstat (limited to 'chip/it83xx/lpc.c')
| -rw-r--r-- | chip/it83xx/lpc.c | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/chip/it83xx/lpc.c b/chip/it83xx/lpc.c index 71ce9fa16b..c860a372b9 100644 --- a/chip/it83xx/lpc.c +++ b/chip/it83xx/lpc.c @@ -720,16 +720,6 @@ void lpc_disable_acpi_interrupts(void) static void lpc_resume(void) { -#ifdef CONFIG_POWER_S0IX - if (chipset_in_state(CHIPSET_STATE_SUSPEND | CHIPSET_STATE_ON)) -#endif - { - /* Mask all host events until the host unmasks them itself. */ - lpc_set_host_event_mask(LPC_HOST_EVENT_SMI, 0); - lpc_set_host_event_mask(LPC_HOST_EVENT_SCI, 0); - lpc_set_host_event_mask(LPC_HOST_EVENT_WAKE, 0); - } - /* Store port 80 event so we know where resume happened */ port_80_write(PORT_80_EVENT_RESUME); } |