diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 15:57:52 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:55 -0700 |
| commit | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (patch) | |
| tree | f6ada087f62246c3a9547e649ac8846b0ed6d5ab /chip/it83xx/system.c | |
| parent | 0bfc511527cf2aebfa163c63a1d028419ca0b0c3 (diff) | |
| download | chrome-ec-bb266fc26fc05d4ab22de6ad7bce5b477c9f9140.tar.gz | |
common: replace 1 << digits, with BIT(digits)
Requested for linux integration, use BIT instead of 1 <<
First step replace bit operation with operand containing only digits.
Fix an error in motion_lid try to set bit 31 of a signed integer.
BUG=None
BRANCH=None
TEST=compile
Change-Id: Ie843611f2f68e241f0f40d4067f7ade726951d29
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518659
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'chip/it83xx/system.c')
| -rw-r--r-- | chip/it83xx/system.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chip/it83xx/system.c b/chip/it83xx/system.c index 98bf0e092a..d4f1987d4d 100644 --- a/chip/it83xx/system.c +++ b/chip/it83xx/system.c @@ -118,7 +118,7 @@ int system_is_reboot_warm(void) void chip_pre_init(void) { /* bit4, enable debug mode through SMBus */ - IT83XX_SMB_SLVISELR &= ~(1 << 4); + IT83XX_SMB_SLVISELR &= ~BIT(4); } #define BRAM_VALID_MAGIC 0x4252414D /* "BRAM" */ @@ -189,12 +189,12 @@ void system_reset(int flags) * If we are in debug mode, we need disable it before triggering * a soft reset or reset will fail. */ - IT83XX_SMB_SLVISELR |= (1 << 4); + IT83XX_SMB_SLVISELR |= BIT(4); /* bit0: enable watchdog hardware reset. */ #ifdef IT83XX_ETWD_HW_RESET_SUPPORT if (flags & SYSTEM_RESET_HARD) - IT83XX_GCTRL_ETWDUARTCR |= (1 << 0); + IT83XX_GCTRL_ETWDUARTCR |= BIT(0); #endif /* * Writing invalid key to watchdog module triggers a soft or hardware |