diff options
| author | Dino Li <dino.li@ite.com.tw> | 2016-01-27 13:44:58 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-01-28 00:02:03 -0800 |
| commit | a313fc9b1aff224f1229f22dafa7564516eb330c (patch) | |
| tree | f3acaed6efa6d3de6c694ae9e1f69f453f5f6c31 /chip/it83xx/uart.c | |
| parent | 347f516d8444a95e0506640f116e102828b89527 (diff) | |
| download | chrome-ec-a313fc9b1aff224f1229f22dafa7564516eb330c.tar.gz | |
chip: it83xx: fix EC interrupt vector registers issue
We have a limitation for EC interrupt vector registers.
System may read incorrect interrupt number in ISR so we need to add
a workaround to prevent it.
The following is a example that got incorrect interrupt number:
1. REG IVCTx = 0x10. (no interrupt pending)
2. EC INT6 interrupt occurs (IVCTx = 0x16) and jump to ISR.
3. Read interrupt vector register to determine interrupt number.
4. Higher priority interrupt of same interrupt group occurs
(for example: INT134, IVCTx = 0x96) while the system is reading the
interrupt vector register for EC INT6, we may end up with an incorrect
interrupt number between 0x16 and 0x96.
Signed-off-by: Dino Li <dino.li@ite.com.tw>
BRANCH=none
BUG=none
TEST=1. EC interrupts work normally: WUI (GPIO interrupt), timer, uart,
LPC, I2C, and PECI.
2. Console command 'taskinfo'.
Change-Id: I54e61f417ad506eb3b4cd5d0652f64eed9a28a17
Reviewed-on: https://chromium-review.googlesource.com/322097
Commit-Ready: Dino Li <dino.li@ite.com.tw>
Tested-by: Dino Li <dino.li@ite.com.tw>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'chip/it83xx/uart.c')
| -rw-r--r-- | chip/it83xx/uart.c | 16 |
1 files changed, 15 insertions, 1 deletions
diff --git a/chip/it83xx/uart.c b/chip/it83xx/uart.c index 207b6cdb40..69c88e93c7 100644 --- a/chip/it83xx/uart.c +++ b/chip/it83xx/uart.c @@ -117,7 +117,21 @@ static void uart_ec_interrupt(void) IT83XX_UART_IER(UART_PORT) = 0; IT83XX_UART_IER(UART_PORT) = uart_ier; } -DECLARE_IRQ(IT83XX_IRQ_UART1, uart_ec_interrupt, 1); + +static void intc_cpu_int_group_9(void) +{ + /* Determine interrupt number. */ + int intc_group_9 = intc_get_ec_int(); + + switch (intc_group_9) { + case IT83XX_IRQ_UART1: + uart_ec_interrupt(); + break; + default: + break; + } +} +DECLARE_IRQ(CPU_INT_GROUP_9, intc_cpu_int_group_9, 1); static void uart_config(void) { |