summaryrefslogtreecommitdiff
path: root/chip/it83xx
diff options
context:
space:
mode:
authorShawn Nematbakhsh <shawnn@chromium.org>2015-05-11 14:23:31 -0700
committerChromeOS Commit Bot <chromeos-commit-bot@chromium.org>2015-05-15 06:42:30 +0000
commite3dce49334a2b44e337744bc719a27c63261f35e (patch)
tree3ee485350fafffaf53206036a3a19184068feeb5 /chip/it83xx
parentcba37a13d2342e4c81b0be3c84010baf3d846162 (diff)
downloadchrome-ec-e3dce49334a2b44e337744bc719a27c63261f35e.tar.gz
cleanup: Use appropriate image geometry CONFIGs
- Use CONFIG_*_MEM when dealing with images in program memory. - Use CONFIG_*_STORAGE when dealing with images on storage. - Use CONFIG_WP when dealing with the entire WP RO region. BUG=chrome-os-partner:39741,chrome-os-partner:23796 TEST=Manual on Cyan with subsequent commit. Verify that FMAP matches actual layout of image. Verify flashrom succeeds flashing + verifying EC image using host command interface. BRANCH=None Change-Id: Iadc02daa89fe3bf07b083ed0f7be2e60702a1867 Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/270269
Diffstat (limited to 'chip/it83xx')
-rw-r--r--chip/it83xx/config_chip.h28
1 files changed, 1 insertions, 27 deletions
diff --git a/chip/it83xx/config_chip.h b/chip/it83xx/config_chip.h
index 5caf50562b..2c433262c9 100644
--- a/chip/it83xx/config_chip.h
+++ b/chip/it83xx/config_chip.h
@@ -56,33 +56,7 @@
/****************************************************************************/
/* Define our flash layout. */
-/* Size of one firmware image in flash */
-#ifndef CONFIG_FW_IMAGE_SIZE
-#define CONFIG_FW_IMAGE_SIZE (CONFIG_FLASH_PHYSICAL_SIZE / 2)
-#endif
-
-/* RO firmware must start at beginning of flash */
-#define CONFIG_RO_MEM_OFF 0
-
-/*
- * The EC uses the one bank of flash to emulate a SPI-like write protect
- * register with persistent state.
- */
-#define CONFIG_FW_PSTATE_SIZE CONFIG_FLASH_BANK_SIZE
-
-/* PSTATE immediately follows RO, in the first half of flash */
-#define CONFIG_RO_SIZE (CONFIG_FW_IMAGE_SIZE \
- - CONFIG_FW_PSTATE_SIZE)
-#define CONFIG_FW_PSTATE_OFF CONFIG_RO_SIZE
-#define CONFIG_FLASH_SIZE CONFIG_FLASH_PHYSICAL_SIZE
-
-/* RW firmware is one firmware image offset from the start */
-#define CONFIG_RW_MEM_OFF CONFIG_FW_IMAGE_SIZE
-#define CONFIG_RW_SIZE CONFIG_FW_IMAGE_SIZE
-
-/* TODO: why 2 sets of configs with the same numbers? */
-#define CONFIG_WP_OFF CONFIG_RO_MEM_OFF
-#define CONFIG_WP_SIZE CONFIG_RO_SIZE
+#include "config_std_internal_flash.h"
/****************************************************************************/
/* Customize the build */