diff options
| author | Furquan Shaikh <furquan@google.com> | 2018-07-25 17:56:49 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-07-27 08:50:52 -0700 |
| commit | f34762305392a078dbc2d871ca7a3859de631007 (patch) | |
| tree | 462ecb944bfbe9a0f47afdd16ecd87e01c8eb8f0 /chip/it83xx | |
| parent | dbbd8098634a8b09562fc714cf2bff36a036e9e7 (diff) | |
| download | chrome-ec-f34762305392a078dbc2d871ca7a3859de631007.tar.gz | |
chip/it83xx: Use CONFIG_HOSTCMD_ESPI to decide PLTRST usage
Currently it83xx chip code relies on CONFIG_HOSTCMD_ESPI_VW_SIGNALS to
decide if PLTRST is over a physical pin or virtual wire. However,
CONFIG_HOSTCMD_ESPI_VW_SIGNALS is used to indicate if sleep signals
go over physical wires or virtual wires. Also, PLTRST# is always
supported over virtual wires when using ESPI and all our designs skip
the physical connection between AP and EC for PLTRST#. This change
updates the check for PLTRST# signal to be based on
CONFIG_HOSTCMD_ESPI instead of CONFIG_HOSTCMD_ESPI_VW_SIGNALS.
BUG=b:111855734
BRANCH=None
TEST=None
Change-Id: Id9b2f1d4804ec5e61c690a23c85e89a5a8b40881
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://chromium-review.googlesource.com/1150921
Commit-Ready: Furquan Shaikh <furquan@chromium.org>
Tested-by: Furquan Shaikh <furquan@chromium.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
Reviewed-by: Scott Collyer <scollyer@chromium.org>
Reviewed-by: Jett Rink <jettrink@chromium.org>
Diffstat (limited to 'chip/it83xx')
| -rw-r--r-- | chip/it83xx/lpc.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chip/it83xx/lpc.c b/chip/it83xx/lpc.c index 19b6ff8a64..5765788718 100644 --- a/chip/it83xx/lpc.c +++ b/chip/it83xx/lpc.c @@ -377,7 +377,7 @@ void lpc_clear_acpi_status_mask(uint8_t mask) pm_set_status(LPC_ACPI_CMD, mask, 0); } -#ifndef CONFIG_HOSTCMD_ESPI_VW_SIGNALS +#ifndef CONFIG_HOSTCMD_ESPI int lpc_get_pltrst_asserted(void) { return !gpio_get_level(GPIO_PCH_PLTRST_L); @@ -677,7 +677,7 @@ static void lpc_init(void) */ IT83XX_GCTRL_SPCTRL1 |= 0xC2; -#ifndef CONFIG_HOSTCMD_ESPI_VW_SIGNALS +#ifndef CONFIG_HOSTCMD_ESPI gpio_enable_interrupt(GPIO_PCH_PLTRST_L); #endif @@ -715,7 +715,7 @@ static void lpc_init(void) */ DECLARE_HOOK(HOOK_INIT, lpc_init, HOOK_PRIO_INIT_LPC); -#ifndef CONFIG_HOSTCMD_ESPI_VW_SIGNALS +#ifndef CONFIG_HOSTCMD_ESPI void lpcrst_interrupt(enum gpio_signal signal) { if (lpc_get_pltrst_asserted()) |