diff options
author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 16:07:55 -0700 |
---|---|---|
committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:56 -0700 |
commit | ac77140b7f4f42075d2377fc9d956a636b05aacf (patch) | |
tree | c64c6a30916ff741a2ab235141f7bd071cd54483 /chip/lm4/fan.c | |
parent | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (diff) | |
download | chrome-ec-ac77140b7f4f42075d2377fc9d956a636b05aacf.tar.gz |
common: bit change 1 << constants with BIT(constants)
Mechanical replacement of bit operation where operand is a constant.
More bit operation exist, but prone to errors.
Reveal a bug in npcx:
chip/npcx/system-npcx7.c:114:54: error: conversion from 'long unsigned int' to 'uint8_t' {aka 'volatile unsigned char'} changes value from '16777215' to '255' [-Werror=overflow]
BUG=None
BRANCH=None
TEST=None
Change-Id: I006614026143fa180702ac0d1cc2ceb1b3c6eeb0
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518660
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'chip/lm4/fan.c')
-rw-r--r-- | chip/lm4/fan.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chip/lm4/fan.c b/chip/lm4/fan.c index 39baa0a03e..c0eee330db 100644 --- a/chip/lm4/fan.c +++ b/chip/lm4/fan.c @@ -32,14 +32,14 @@ void fan_set_enabled(int ch, int enabled) { if (enabled) - LM4_FAN_FANCTL |= (1 << ch); + LM4_FAN_FANCTL |= BIT(ch); else - LM4_FAN_FANCTL &= ~(1 << ch); + LM4_FAN_FANCTL &= ~BIT(ch); } int fan_get_enabled(int ch) { - return (LM4_FAN_FANCTL & (1 << ch)) ? 1 : 0; + return (LM4_FAN_FANCTL & BIT(ch)) ? 1 : 0; } void fan_set_duty(int ch, int percent) |