diff options
author | Vic Yang <victoryang@chromium.org> | 2014-05-19 15:03:27 -0700 |
---|---|---|
committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-05-21 20:32:17 +0000 |
commit | ffac23c0ea1bd4ff4568f5bd709a98f912b833a7 (patch) | |
tree | 362dd0ba205731aa07be97dd35b44b237799b23b /chip/lm4/lpc.c | |
parent | 478361de694b1fb45abf3c38dafbbf7fd1aa5f71 (diff) | |
download | chrome-ec-ffac23c0ea1bd4ff4568f5bd709a98f912b833a7.tar.gz |
Add cprints() and ccprints()
Our code base contains a lot of debug messages in this pattern:
CPRINTF("[%T xxx]\n") or ccprintf("[%T xxx]\n")
The strings are taking up spaces in the EC binaries, so let's refactor
this by adding cprints() and ccprints().
cprints() is just like cprintf(), except that it adds the brackets
and the timestamp. ccprints() is equivalent to cprints(CC_CONSOLE, ...)
This saves us hundreds of bytes in EC binaries.
BUG=chromium:374575
TEST=Build and check flash size
BRANCH=None
Change-Id: Ifafe8dc1b80e698b28ed42b70518c7917b49ee51
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/200490
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'chip/lm4/lpc.c')
-rw-r--r-- | chip/lm4/lpc.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/chip/lm4/lpc.c b/chip/lm4/lpc.c index ef273be8b8..8f8c5434a4 100644 --- a/chip/lm4/lpc.c +++ b/chip/lm4/lpc.c @@ -52,7 +52,7 @@ /* Console output macros */ #define CPUTS(outstr) cputs(CC_LPC, outstr) -#define CPRINTF(format, args...) cprintf(CC_LPC, format, ## args) +#define CPRINTS(format, args...) cprints(CC_LPC, format, ## args) #define LPC_SYSJUMP_TAG 0x4c50 /* "LP" */ @@ -158,7 +158,7 @@ static void lpc_generate_smi(void) gpio_set_level(GPIO_PCH_SMI_L, 1); if (host_events & event_mask[LPC_HOST_EVENT_SMI]) - CPRINTF("[%T smi 0x%08x]\n", + CPRINTS("smi 0x%08x", host_events & event_mask[LPC_HOST_EVENT_SMI]); } @@ -181,7 +181,7 @@ static void lpc_generate_sci(void) #endif if (host_events & event_mask[LPC_HOST_EVENT_SCI]) - CPRINTF("[%T sci 0x%08x]\n", + CPRINTS("sci 0x%08x", host_events & event_mask[LPC_HOST_EVENT_SCI]); } @@ -622,7 +622,7 @@ void lpc_interrupt(void) LM4_LPC_ST(i) &= ~LM4_LPC_ST_FRMH; } - CPRINTF("[%T LPC RESET# %sasserted]\n", + CPRINTS("LPC RESET# %sasserted", lpc_get_pltrst_asserted() ? "" : "de"); } } |