cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.

We're never going to use this, let's just get rid of it.

BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware

Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.

Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

7 files changed, 15 insertions, 30 deletions

diff --git a/chip/lm4/adc.c b/chip/lm4/adc.c
index 82f28153e4..278908151c 100644
--- a/chip/lm4/adc.c
+++ b/chip/lm4/adc.c
@@ -214,8 +214,7 @@ static int command_ectemp(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(ectemp, command_ectemp,
 			NULL,
-			"Print EC temperature",
-			NULL);
+			"Print EC temperature");
 #endif
 
 /*****************************************************************************/
diff --git a/chip/lm4/clock.c b/chip/lm4/clock.c
index b8029f5d27..bc4b865403 100644
--- a/chip/lm4/clock.c
+++ b/chip/lm4/clock.c
@@ -551,8 +551,7 @@ static int command_sleep(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(sleep, command_sleep,
 			"[level [clock] [sram pm] [flash pm]]",
-			"Drop into sleep",
-			NULL);
+			"Drop into sleep");
 #endif /* CONFIG_CMD_SLEEP */
 
 #ifdef CONFIG_CMD_PLL
@@ -594,8 +593,7 @@ static int command_pll(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(pll, command_pll,
 			"[ on | off | <div> ]",
-			"Get/set PLL state",
-			NULL);
+			"Get/set PLL state");
 
 #endif /* CONFIG_CMD_PLL */
 
@@ -681,8 +679,7 @@ static int command_clock_gating(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(clockgates, command_clock_gating,
 			"",
-			"Get state of the clock gating controls regs",
-			NULL);
+			"Get state of the clock gating controls regs");
 #endif /* CONFIG_CMD_CLOCKGATES */
 
 #ifdef CONFIG_LOW_POWER_IDLE
@@ -705,8 +702,7 @@ static int command_idle_stats(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(idlestats, command_idle_stats,
 			"",
-			"Print last idle stats",
-			NULL);
+			"Print last idle stats");
 
 /**
  * Configure deep sleep clock settings.
@@ -753,7 +749,6 @@ DECLARE_CONSOLE_COMMAND(dsleep, command_dsleep,
 			"allow deep sleep to auto-select using the low speed "
 			"clock.\n"
 			"Give a timeout value for the console in use timeout.\n"
-			"See also 'sleepmask'.",
-			NULL);
+			"See also 'sleepmask'.");
 #endif /* CONFIG_LOW_POWER_IDLE */
 
diff --git a/chip/lm4/eeprom.c b/chip/lm4/eeprom.c
index b8c45c23e2..81fb47465d 100644
--- a/chip/lm4/eeprom.c
+++ b/chip/lm4/eeprom.c
@@ -146,8 +146,7 @@ static int command_eeprom_info(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(eeinfo, command_eeprom_info,
 			NULL,
-			"Print EEPROM info",
-			NULL);
+			"Print EEPROM info");
 
 
 static int command_eeprom_read(int argc, char **argv)
@@ -178,8 +177,7 @@ static int command_eeprom_read(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(eeread, command_eeprom_read,
 			"block [offset]",
-			"Read a word of EEPROM",
-			NULL);
+			"Read a word of EEPROM");
 
 
 static int command_eeprom_write(int argc, char **argv)
@@ -207,8 +205,7 @@ static int command_eeprom_write(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(eewrite, command_eeprom_write,
 			"block offset value",
-			"Write a word of EEPROM",
-			NULL);
+			"Write a word of EEPROM");
 
 
 #ifdef CONSOLE_COMMAND_EEHIDE
@@ -229,8 +226,7 @@ static int command_eeprom_hide(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(eehide, command_eeprom_hide,
 			"block",
-			"Hide a block of EEPROM",
-			NULL);
+			"Hide a block of EEPROM");
 #endif
 
 
diff --git a/chip/lm4/peci.c b/chip/lm4/peci.c
index 44c1699d26..70f65b5837 100644
--- a/chip/lm4/peci.c
+++ b/chip/lm4/peci.c
@@ -149,5 +149,4 @@ static int command_peci_temp(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(pecitemp, command_peci_temp,
 			NULL,
-			"Print CPU temperature",
-			NULL);
+			"Print CPU temperature");
diff --git a/chip/lm4/spi.c b/chip/lm4/spi.c
index 60394bb936..3fd3bc96de 100644
--- a/chip/lm4/spi.c
+++ b/chip/lm4/spi.c
@@ -184,5 +184,4 @@ static int command_spirom(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(spirom, command_spirom,
 			NULL,
-			"Test reading SPI EEPROM",
-			NULL);
+			"Test reading SPI EEPROM");
diff --git a/chip/lm4/system.c b/chip/lm4/system.c
index 5fec905517..26cd0f2967 100644
--- a/chip/lm4/system.c
+++ b/chip/lm4/system.c
@@ -650,8 +650,7 @@ static int command_system_rtc(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(rtc, command_system_rtc,
 			"[set <seconds>]",
-			"Get/set real-time clock",
-			NULL);
+			"Get/set real-time clock");
 
 #ifdef CONFIG_CMD_RTC_ALARM
 /**
@@ -684,8 +683,7 @@ static int command_rtc_alarm_test(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(rtc_alarm, command_rtc_alarm_test,
 			"[seconds [microseconds]]",
-			"Test alarm",
-			NULL);
+			"Test alarm");
 #endif /* CONFIG_CMD_RTC_ALARM */
 #endif /* CONFIG_CMD_RTC */
 
diff --git a/chip/lm4/uart.c b/chip/lm4/uart.c
index 6ef44f8dc4..21fdf70ec9 100644
--- a/chip/lm4/uart.c
+++ b/chip/lm4/uart.c
@@ -347,7 +347,6 @@ static int command_comxtest(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(comxtest, command_comxtest,
 			"[string]",
-			"Write test data to COMx uart",
-			NULL);
+			"Write test data to COMx uart");
 
 #endif /* CONFIG_CMD_COMXTEST */