diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 15:57:52 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:55 -0700 |
| commit | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (patch) | |
| tree | f6ada087f62246c3a9547e649ac8846b0ed6d5ab /chip/mchp/fan.c | |
| parent | 0bfc511527cf2aebfa163c63a1d028419ca0b0c3 (diff) | |
| download | chrome-ec-bb266fc26fc05d4ab22de6ad7bce5b477c9f9140.tar.gz | |
common: replace 1 << digits, with BIT(digits)
Requested for linux integration, use BIT instead of 1 <<
First step replace bit operation with operand containing only digits.
Fix an error in motion_lid try to set bit 31 of a signed integer.
BUG=None
BRANCH=None
TEST=compile
Change-Id: Ie843611f2f68e241f0f40d4067f7ade726951d29
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518659
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'chip/mchp/fan.c')
| -rw-r--r-- | chip/mchp/fan.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/chip/mchp/fan.c b/chip/mchp/fan.c index 6f89f06673..dc939bb58f 100644 --- a/chip/mchp/fan.c +++ b/chip/mchp/fan.c @@ -82,15 +82,15 @@ int fan_get_duty(int ch) int fan_get_rpm_mode(int ch) { - return !!(MCHP_FAN_CFG1(0) & (1 << 7)); + return !!(MCHP_FAN_CFG1(0) & BIT(7)); } void fan_set_rpm_mode(int ch, int rpm_mode) { if (rpm_mode) - MCHP_FAN_CFG1(0) |= 1 << 7; + MCHP_FAN_CFG1(0) |= BIT(7); else - MCHP_FAN_CFG1(0) &= ~(1 << 7); + MCHP_FAN_CFG1(0) &= ~BIT(7); clear_status(); } @@ -118,7 +118,7 @@ enum fan_status fan_get_status(int ch) { uint8_t sts = MCHP_FAN_STATUS(0); - if (sts & ((1 << 5) | (1 << 1))) + if (sts & (BIT(5) | BIT(1))) return FAN_STATUS_FRUSTRATED; if (fan_get_rpm_actual(ch) == 0) return FAN_STATUS_STOPPED; |