diff options
| author | Evan Green <evgreen@chromium.org> | 2019-10-01 13:39:24 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-10-05 00:47:56 +0000 |
| commit | 1d82a0592eedcfdaf666111a4ff8e6a9665fa014 (patch) | |
| tree | 02d30616c04b4e945647dacfb6d254223a593a9f /chip/mec1322 | |
| parent | 3247d52abeb0ccacc49f0d18dadf47c77f8f0177 (diff) | |
| download | chrome-ec-1d82a0592eedcfdaf666111a4ff8e6a9665fa014.tar.gz | |
include: De-longify BIT() macro
The BIT() macro was recently introduced to make things more
comfortable to upstream Linux. However, there's no need for it to
be a long.
Change the macro back to being an int (int and long are the same on
32-bit platforms, which all of our ECs are), so that we can reduce
the number of %l specifiers. The semantics of %l have changed, we
are deprecating its use on master to reduce the risk that we
accidentally cherry-pick one of those printfs to an old firmware
branch.
BUG=chromium:984041
TEST=make -j buildall
BRANCH=None
Change-Id: I95b9cd49895cc67998dcb1de9bab5b5591d93243
Signed-off-by: Evan Green <evgreen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1834601
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-by: caveh jalali <caveh@chromium.org>
Diffstat (limited to 'chip/mec1322')
| -rw-r--r-- | chip/mec1322/i2c.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chip/mec1322/i2c.c b/chip/mec1322/i2c.c index 5d44f362ea..6a0fa0a5cc 100644 --- a/chip/mec1322/i2c.c +++ b/chip/mec1322/i2c.c @@ -265,7 +265,7 @@ int chip_i2c_xfer(const int port, (((reg & (STS_BER | STS_LAB)) || !(reg & STS_NBB)) || (get_line_level(controller) != I2C_LINE_IDLE))) { - CPRINTS("i2c%s bad status 0x%02x, SCL=%ld, SDA=%ld", + CPRINTS("i2c%s bad status 0x%02x, SCL=%d, SDA=%d", i2c_port_names[port], reg, get_line_level(controller) & I2C_LINE_SCL_HIGH, get_line_level(controller) & I2C_LINE_SDA_HIGH); |