diff options
| author | Gwendal Grignou <gwendal@chromium.org> | 2019-03-11 16:07:55 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-03-26 04:42:56 -0700 |
| commit | ac77140b7f4f42075d2377fc9d956a636b05aacf (patch) | |
| tree | c64c6a30916ff741a2ab235141f7bd071cd54483 /chip/npcx/cec.c | |
| parent | bb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (diff) | |
| download | chrome-ec-ac77140b7f4f42075d2377fc9d956a636b05aacf.tar.gz | |
common: bit change 1 << constants with BIT(constants)
Mechanical replacement of bit operation where operand is a constant.
More bit operation exist, but prone to errors.
Reveal a bug in npcx:
chip/npcx/system-npcx7.c:114:54: error: conversion from 'long unsigned int' to 'uint8_t' {aka 'volatile unsigned char'} changes value from '16777215' to '255' [-Werror=overflow]
BUG=None
BRANCH=None
TEST=None
Change-Id: I006614026143fa180702ac0d1cc2ceb1b3c6eeb0
Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1518660
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'chip/npcx/cec.c')
| -rw-r--r-- | chip/npcx/cec.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chip/npcx/cec.c b/chip/npcx/cec.c index d996695dfc..8c544c5970 100644 --- a/chip/npcx/cec.c +++ b/chip/npcx/cec.c @@ -791,7 +791,7 @@ void cec_isr(void) /* Retrieve events NPCX_TECTRL_TAXND */ events = GET_FIELD(NPCX_TECTRL(mdl), FIELD(0, 4)); - if (events & (1 << NPCX_TECTRL_TAPND)) { + if (events & BIT(NPCX_TECTRL_TAPND)) { /* Capture event */ cec_event_cap(); } else { @@ -801,11 +801,11 @@ void cec_isr(void) * happening, since we will get both events in the * edge-trigger case */ - if (events & (1 << NPCX_TECTRL_TCPND)) + if (events & BIT(NPCX_TECTRL_TCPND)) cec_event_timeout(); } /* Oneshot timer, a transfer has been initiated from AP */ - if (events & (1 << NPCX_TECTRL_TDPND)) { + if (events & BIT(NPCX_TECTRL_TDPND)) { tmr2_stop(); cec_event_tx(); } |