diff options
| author | raymondchou <raymond_chou@compal.corp-partner.google.com> | 2018-02-07 11:04:38 +0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-03-03 02:50:48 -0800 |
| commit | d87c684288ed1c40615b1c2784ba426ad9655dcd (patch) | |
| tree | 718f1bdbb5b4eab743d7ba88c7f22d26b391eed9 /chip/npcx/fan.c | |
| parent | 6790a884a46f18e858a6b308d3b00f86ef915e3f (diff) | |
| download | chrome-ec-d87c684288ed1c40615b1c2784ba426ad9655dcd.tar.gz | |
Nami: Enable fan feature
1. Enable fan feature and update fan setting.
2. Enable SW and chipset throttle feature.
3. Fix the issue that cannot set fan duty by "fanduty" in EC console.
BUG=b:72974136
BRANCH=none
TEST=Check fan command(fanduty/fanset/fanauto) in EC console can work and
check below condition.
1.AP throttling soft
--> Increased temperature to over trigger point, then to check
EC notify event in EC console.
2.AP throttling hard
--> Increased temperature to over trigger point, then to check
EC notify event and CPU_PROCHOT pin status in EC console.
3.Fan controlled in s3/s5 as expected (by EC)
--> Check Fan turn off in s3/s5.
4.Fan controlled in S0 as expected (by DPTF)
--> Check Fan keep 100% duty and no see DPTF to set fan duty.
But fan duty can be control by "fanduty" in EC console.
Change-Id: If9fd7f64c123ff54742052b6310023f0d4b0113a
Signed-off-by: raymondchou <raymond_chou@compal.corp-partner.google.com>
Reviewed-on: https://chromium-review.googlesource.com/906086
Commit-Ready: Raymond Chou <raymond_chou@compal.corp-partner.google.com>
Tested-by: Raymond Chou <raymond_chou@compal.corp-partner.google.com>
Reviewed-by: Raymond Chou <raymond_chou@compal.corp-partner.google.com>
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'chip/npcx/fan.c')
| -rw-r--r-- | chip/npcx/fan.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chip/npcx/fan.c b/chip/npcx/fan.c index 123dd35518..db5abd1742 100644 --- a/chip/npcx/fan.c +++ b/chip/npcx/fan.c @@ -52,7 +52,7 @@ enum tacho_fan_mode { /* FAN rpm mode */ TACHO_FAN_RPM = 0, /* FAN duty mode */ - TACHO_FAN_DUTY = 0, + TACHO_FAN_DUTY, }; /* Fan status data structure */ |