diff options
author | Vadim Bendebury <vbendeb@chromium.org> | 2019-06-18 13:25:44 -0700 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2019-06-20 01:29:33 +0000 |
commit | bbe3abd8dbee0a91b5bfad214821768610b10371 (patch) | |
tree | def2a7b49fa5a19c7b7badf1ff31aebc40bebbed /chip/npcx/i2c.c | |
parent | e4fdb9124042cb21ecfb3df8004f0697756bbbad (diff) | |
download | chrome-ec-bbe3abd8dbee0a91b5bfad214821768610b10371.tar.gz |
presubmit: add check for newlines in CPRINTS strings
There should be no newlines in string parameters of the CPRINTS()
macro, it adds a newline unconditionally.
BRANCH=none
BUG=none
TEST=created a failing patch and observed expected error message:
. $ ./util/presubmit_check.sh
. +++ b/chip/g/usb-stream.c
. + CPRINTS("this is a bad, bad, string\n", yes);
. error: CPRINTS strings should not include newline characters
Change-Id: I9b6338743d2493aa731dd49ae35f9de043fd860b
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1665449
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'chip/npcx/i2c.c')
0 files changed, 0 insertions, 0 deletions