diff options
| author | Aseda Aboagye <aaboagye@google.com> | 2015-07-14 15:06:21 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-08-01 02:52:37 +0000 |
| commit | d74949e3e68c000ead762d5acf42a5e967d2d976 (patch) | |
| tree | ba38ef96120726a6ae786df5666025f9dc7c8c9f /chip/npcx | |
| parent | e2f233faafe2b7932fad0f03ef2ecd73c0b8abef (diff) | |
| download | chrome-ec-d74949e3e68c000ead762d5acf42a5e967d2d976.tar.gz | |
tasks: Remove most task_start_called() calls.
Now that HOOK_INIT hooks are called from a task switching context, most
calls to task_start_called() should no longer be needed. This commit
removes them.
BRANCH=None
BUG=chrome-os-partner:27226
TEST=make -j buildall tests
TEST=Flash EC image onto samus and verify EC boot, AP boot, keyboard,
lid, and tap-for-battery all functional.
TEST=Flash EC image onto samus_pd and verify charging still works.
TEST=Flash EC image onto ryu(P3) and verify that EC boot.
TEST=Added ASSERT(task_start_called()) to the places where I removed
task_start_called(). Booted samus, samus_pd, cyan, and ryu with AC
inserted and verified that no ASSERT's were hit upon boot.
Change-Id: Ic12c61862e85ca3a0a295beedbb4eeee6d5e515b
Signed-off-by: Aseda Aboagye <aaboagye@google.com>
Reviewed-on: https://chromium-review.googlesource.com/285635
Tested-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-by: Shawn N <shawnn@chromium.org>
Commit-Queue: Aseda Aboagye <aaboagye@chromium.org>
Trybot-Ready: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'chip/npcx')
| -rw-r--r-- | chip/npcx/flash.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/chip/npcx/flash.c b/chip/npcx/flash.c index 161f65b6d1..2780e379de 100644 --- a/chip/npcx/flash.c +++ b/chip/npcx/flash.c @@ -88,9 +88,7 @@ void flash_wait_ready(void) if ((NPCX_UMA_DB0 & mask) == 0) break; - /* check task scheduling has started to prevent infinite loop */ - if (task_start_called()) - msleep(1); + msleep(1); }; /* Wait for Busy clear */ /* Chip Select high. */ flash_cs_level(1); |