summaryrefslogtreecommitdiff
path: root/chip/nrf51/gpio.c
diff options
context:
space:
mode:
authorGwendal Grignou <gwendal@chromium.org>2019-03-11 16:07:55 -0700
committerchrome-bot <chrome-bot@chromium.org>2019-03-26 04:42:56 -0700
commitac77140b7f4f42075d2377fc9d956a636b05aacf (patch)
treec64c6a30916ff741a2ab235141f7bd071cd54483 /chip/nrf51/gpio.c
parentbb266fc26fc05d4ab22de6ad7bce5b477c9f9140 (diff)
downloadchrome-ec-ac77140b7f4f42075d2377fc9d956a636b05aacf.tar.gz
common: bit change 1 << constants with BIT(constants)
Mechanical replacement of bit operation where operand is a constant. More bit operation exist, but prone to errors. Reveal a bug in npcx: chip/npcx/system-npcx7.c:114:54: error: conversion from 'long unsigned int' to 'uint8_t' {aka 'volatile unsigned char'} changes value from '16777215' to '255' [-Werror=overflow] BUG=None BRANCH=None TEST=None Change-Id: I006614026143fa180702ac0d1cc2ceb1b3c6eeb0 Signed-off-by: Gwendal Grignou <gwendal@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1518660 Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Diffstat (limited to 'chip/nrf51/gpio.c')
-rw-r--r--chip/nrf51/gpio.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/chip/nrf51/gpio.c b/chip/nrf51/gpio.c
index 3ad55f2b38..a01ee49940 100644
--- a/chip/nrf51/gpio.c
+++ b/chip/nrf51/gpio.c
@@ -164,7 +164,7 @@ void gpio_set_alternate_function(uint32_t port, uint32_t mask, int func)
{
uint32_t bit = GPIO_MASK_TO_NUM(mask);
- ASSERT((~mask & (1 << bit)) == 0); /* Only one bit set. */
+ ASSERT((~mask & BIT(bit)) == 0); /* Only one bit set. */
ASSERT(port == GPIO_0);
ASSERT((func >= 0 && func < nrf51_alt_func_count) || func == -1);