diff options
| author | Vic Yang <victoryang@chromium.org> | 2014-05-19 15:03:27 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-05-21 20:32:17 +0000 |
| commit | ffac23c0ea1bd4ff4568f5bd709a98f912b833a7 (patch) | |
| tree | 362dd0ba205731aa07be97dd35b44b237799b23b /chip/stm32/spi.c | |
| parent | 478361de694b1fb45abf3c38dafbbf7fd1aa5f71 (diff) | |
| download | chrome-ec-ffac23c0ea1bd4ff4568f5bd709a98f912b833a7.tar.gz | |
Add cprints() and ccprints()
Our code base contains a lot of debug messages in this pattern:
CPRINTF("[%T xxx]\n") or ccprintf("[%T xxx]\n")
The strings are taking up spaces in the EC binaries, so let's refactor
this by adding cprints() and ccprints().
cprints() is just like cprintf(), except that it adds the brackets
and the timestamp. ccprints() is equivalent to cprints(CC_CONSOLE, ...)
This saves us hundreds of bytes in EC binaries.
BUG=chromium:374575
TEST=Build and check flash size
BRANCH=None
Change-Id: Ifafe8dc1b80e698b28ed42b70518c7917b49ee51
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/200490
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'chip/stm32/spi.c')
| -rw-r--r-- | chip/stm32/spi.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/chip/stm32/spi.c b/chip/stm32/spi.c index c9e57cd5b2..960067f955 100644 --- a/chip/stm32/spi.c +++ b/chip/stm32/spi.c @@ -21,7 +21,7 @@ /* Console output macros */ #define CPUTS(outstr) cputs(CC_SPI, outstr) -#define CPRINTF(format, args...) cprintf(CC_SPI, format, ## args) +#define CPRINTS(format, args...) cprints(CC_SPI, format, ## args) /* DMA channel option */ static const struct dma_option dma_tx_option = { @@ -346,7 +346,7 @@ void spi_event(enum gpio_signal signal) * AP started a transaction but we weren't ready for it. * Tell AP we weren't ready, and ignore the received data. */ - CPRINTF("[%T SPI not ready]\n"); + CPRINTS("SPI not ready"); spi->dr = EC_SPI_NOT_READY; state = SPI_STATE_RX_BAD; return; @@ -452,7 +452,7 @@ void spi_event(enum gpio_signal signal) /* Error, timeout, or protocol we can't handle. Ignore data. */ spi->dr = EC_SPI_RX_BAD_DATA; state = SPI_STATE_RX_BAD; - CPRINTF("[%T SPI rx bad data\n]"); + CPRINTS("SPI rx bad data"); } static void spi_chipset_startup(void) |