cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args

Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.

We're never going to use this, let's just get rid of it.

BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware

Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.

Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>

9 files changed, 9 insertions, 18 deletions

diff --git a/chip/stm32/clock-f.c b/chip/stm32/clock-f.c
index 02773dc678..1d28fa2168 100644
--- a/chip/stm32/clock-f.c
+++ b/chip/stm32/clock-f.c
@@ -203,7 +203,6 @@ static int command_rtc_alarm_test(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(rtc_alarm, command_rtc_alarm_test,
 			"[seconds [microseconds]]",
-			"Test alarm",
-			NULL);
+			"Test alarm");
 #endif /* CONFIG_CMD_RTC_ALARM */
 
diff --git a/chip/stm32/clock-stm32f0.c b/chip/stm32/clock-stm32f0.c
index 98c39694f2..b94641ef0a 100644
--- a/chip/stm32/clock-stm32f0.c
+++ b/chip/stm32/clock-stm32f0.c
@@ -412,7 +412,6 @@ static int command_idle_stats(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(idlestats, command_idle_stats,
 			"",
-			"Print last idle stats",
-			NULL);
+			"Print last idle stats");
 #endif /* CONFIG_CMD_IDLE_STATS */
 #endif
diff --git a/chip/stm32/clock-stm32l.c b/chip/stm32/clock-stm32l.c
index c8b8bc0683..709d53f902 100644
--- a/chip/stm32/clock-stm32l.c
+++ b/chip/stm32/clock-stm32l.c
@@ -373,5 +373,4 @@ static int command_clock(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(clock, command_clock,
 			"hsi | msi",
-			"Set clock frequency",
-			NULL);
+			"Set clock frequency");
diff --git a/chip/stm32/clock-stm32l4.c b/chip/stm32/clock-stm32l4.c
index 1e825e5c39..499c327baf 100644
--- a/chip/stm32/clock-stm32l4.c
+++ b/chip/stm32/clock-stm32l4.c
@@ -386,5 +386,4 @@ DECLARE_CONSOLE_COMMAND(clock, command_clock,
 			" | hse | pll"
 #endif
 			,
-			"Set clock frequency",
-			NULL);
+			"Set clock frequency");
diff --git a/chip/stm32/i2c-stm32l.c b/chip/stm32/i2c-stm32l.c
index cdca08a25a..136a9413ac 100644
--- a/chip/stm32/i2c-stm32l.c
+++ b/chip/stm32/i2c-stm32l.c
@@ -419,5 +419,4 @@ static int command_i2cdump(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(i2cdump, command_i2cdump,
 			NULL,
-			"Dump I2C regs",
-			NULL);
+			"Dump I2C regs");
diff --git a/chip/stm32/power_led.c b/chip/stm32/power_led.c
index 03a7f33a82..c6d4665e84 100644
--- a/chip/stm32/power_led.c
+++ b/chip/stm32/power_led.c
@@ -158,6 +158,5 @@ static int command_powerled(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(powerled, command_powerled,
 		"[off | on | suspend]",
-		"Change power LED state",
-		NULL);
+		"Change power LED state");
 #endif
diff --git a/chip/stm32/usart_info_command.c b/chip/stm32/usart_info_command.c
index 836dc6d84c..f6a76d99f3 100644
--- a/chip/stm32/usart_info_command.c
+++ b/chip/stm32/usart_info_command.c
@@ -40,5 +40,4 @@ static int command_usart_info(int argc, char **argv)
 DECLARE_CONSOLE_COMMAND(usart_info,
 			command_usart_info,
 			NULL,
-			"Display USART info",
-			NULL);
+			"Display USART info");
diff --git a/chip/stm32/usb.c b/chip/stm32/usb.c
index 82b0926702..a3de00f53a 100644
--- a/chip/stm32/usb.c
+++ b/chip/stm32/usb.c
@@ -515,6 +515,5 @@ static int command_serialno(int argc, char **argv)
 
 DECLARE_CONSOLE_COMMAND(serialno, command_serialno,
 	"load/set [value]",
-	"Read and write USB serial number",
-	NULL);
+	"Read and write USB serial number");
 #endif
diff --git a/chip/stm32/usb_hid.c b/chip/stm32/usb_hid.c
index 1f01ec8dc8..ddf1c3ccec 100644
--- a/chip/stm32/usb_hid.c
+++ b/chip/stm32/usb_hid.c
@@ -160,5 +160,4 @@ static int command_hid(int argc, char **argv)
 }
 DECLARE_CONSOLE_COMMAND(hid, command_hid,
 			"[<HID keycode>]",
-			"test USB HID driver",
-			NULL);
+			"test USB HID driver");