diff options
| author | Rob Barnes <robbarnes@google.com> | 2021-08-20 13:44:55 -0600 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-08-31 20:46:49 +0000 |
| commit | dd6cd906da2a08b150ee28c8064e56d90459019f (patch) | |
| tree | 8b55de00da3a66531668dea3ffcd1905909bffb5 /chip | |
| parent | a7370241e9f5f857d3460ef711dae4d3c5d43f0e (diff) | |
| download | chrome-ec-dd6cd906da2a08b150ee28c8064e56d90459019f.tar.gz | |
npcx: Always print on eSPI bus error
The npcx eSPI driver only prints if eSPI_DEBUG is on. Without ESPI_DEBUG,
critical eSPI errors are hidden and it may not be obvious why the
system is failing. This change forces eSPI bus error messages to always
print.
This is inside of an interrupt_handler, so printing too much could
cause other interrupts to be missed. The error message is short and it
did not cause additional errors during testing. Since eSPI bus errors
are often fatal, this risk is acceptable.
BUG=None
TEST=Boot image with known eSPI errors, see error message
Boot with known good image, see no error message
Remove condition, boot good image, eSPI functions normally
BRANCH=None
Change-Id: Ic1431800560091001b73dafcd77362e061323c1a
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3111457
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Diana Z <dzigterman@chromium.org>
Diffstat (limited to 'chip')
| -rw-r--r-- | chip/npcx/espi.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/chip/npcx/espi.c b/chip/npcx/espi.c index a8429afe89..c8976afed0 100644 --- a/chip/npcx/espi.c +++ b/chip/npcx/espi.c @@ -561,7 +561,8 @@ void espi_interrupt(void) NPCX_ESPISTS = status; if (IS_BIT_SET(status, NPCX_ESPISTS_BERR)) - CPRINTS("eSPI Bus Error"); + /* Always print eSPI Bus Errors */ + cprints(CC_LPC, "eSPI Bus Error"); /* eSPI inband reset(from VW) */ if (IS_BIT_SET(status, NPCX_ESPISTS_IBRST)) { |