summaryrefslogtreecommitdiff
path: root/chip
diff options
context:
space:
mode:
authorShawn Nematbakhsh <shawnn@chromium.org>2016-09-14 15:42:56 -0700
committerchrome-bot <chrome-bot@chromium.org>2016-09-16 21:59:08 -0700
commitfd418235953ed853bbb2093d307679604e539902 (patch)
treeaa2a50afcffb789c5e87c1ef5e163e17470b3da2 /chip
parent258bc48bacf948e7f95b98bfc847c3cc0d5f515d (diff)
downloadchrome-ec-fd418235953ed853bbb2093d307679604e539902.tar.gz
flash: Call lock function prior to mapped external read
Mapped read access to external flash may conflict with direct access through SPI commands, so call a chip-level function to lock access prior to doing such reads. BUG=chrome-os-partner:55781 BRANCH=Gru TEST=Verify 'ver' still works fine on kevin, and vboot hashing completes successfully. Change-Id: I009d6d5ee61c83260fb49ad4ee137fa3f4cd625a Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/385165 Tested-by: Mulin Chao <mlchao@nuvoton.com> Reviewed-by: Randall Spangler <rspangler@chromium.org> Reviewed-by: Mulin Chao <mlchao@nuvoton.com> (cherry picked from commit a7f3e3fa376731709f4823a0c1d464b4d1deae14) Reviewed-on: https://chromium-review.googlesource.com/386446 Commit-Ready: Shawn N <shawnn@chromium.org> Tested-by: Shawn N <shawnn@chromium.org> Reviewed-by: Shawn N <shawnn@chromium.org>
Diffstat (limited to 'chip')
-rw-r--r--chip/npcx/flash.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/chip/npcx/flash.c b/chip/npcx/flash.c
index 95b4796bb3..ac1a06078d 100644
--- a/chip/npcx/flash.c
+++ b/chip/npcx/flash.c
@@ -777,6 +777,13 @@ int flash_pre_init(void)
return EC_SUCCESS;
}
+void flash_lock_mapped_storage(int lock)
+{
+ /*
+ * TODO(crosbug.com/p/55781): Add mutex to ensure no conflict between
+ * mapped read and regular flash ops.
+ */
+}
/*****************************************************************************/
/* Console commands */