diff options
author | Mary Ruthven <mruthven@chromium.org> | 2021-01-06 08:50:24 -0800 |
---|---|---|
committer | Commit Bot <commit-bot@chromium.org> | 2021-01-08 00:24:12 +0000 |
commit | a1b83207fbbeb97471cb234576af59287a5d88ed (patch) | |
tree | 395333c47a5d43973e08a3488550de1d8ec1d0cf /chip | |
parent | 22088bd1a47ed7f09f35e5b4dd1efdc45b5855a3 (diff) | |
download | chrome-ec-a1b83207fbbeb97471cb234576af59287a5d88ed.tar.gz |
coil: cleanup i2c comments
Remove coil terms from i2c comments
BUG=b:175244613
TEST=make buildall -j
Change-Id: If056c099304e1fa676991e22ddaa9cb91ccfdeb3
Signed-off-by: Mary Ruthven <mruthven@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2613509
Reviewed-by: Namyoon Woo <namyoon@chromium.org>
Diffstat (limited to 'chip')
-rw-r--r-- | chip/g/i2cc.c | 16 | ||||
-rw-r--r-- | chip/g/i2cp.c | 78 | ||||
-rw-r--r-- | chip/g/i2cp.h | 14 | ||||
-rw-r--r-- | chip/g/ite_flash.c | 11 | ||||
-rw-r--r-- | chip/lm4/i2c.c | 12 |
5 files changed, 64 insertions, 67 deletions
diff --git a/chip/g/i2cc.c b/chip/g/i2cc.c index ad80c3b724..b2f2fcaef9 100644 --- a/chip/g/i2cc.c +++ b/chip/g/i2cc.c @@ -4,7 +4,7 @@ */ /* - * This is a driver for the I2C controller interface (i2cc) of the g chip. + * This is a driver for the I2C controller driver (i2cc) of the g chip. * * The g chip i2cc module supports 3 modes of operation, disabled, bit-banging, * and instruction based. These modes are selected via the I2C_CTRL @@ -34,10 +34,10 @@ * compound instruction for the transaction: * * I2C_INST_START = 1 -> send start bit - * I2C_INST_FWDEVADDR = 1 -> first send the slave device address + * I2C_INST_FWDEVADDR = 1 -> first send the periph device address * I2C_INST_FWBYTESCOUNT = 3 -> 3 bytes in FWBYTES (register + 16 bit value) * I2C_INST_FINALSTOP = 1 -> send stop bit - * I2C_INST_DEVADDRVAL = slave address + * I2C_INST_DEVADDRVAL = periph address * * I2C_FWBYTES[b7:b0] = out[0] -> register address * I2C_FWBYTES[b15:b8] = out[1] -> first byte of value @@ -47,14 +47,14 @@ * compound instruction for the transaction: * * I2C_INST_START = 1 -> send start bit - * I2C_INST_FWDEVADDR = 1 -> first send the slave device address + * I2C_INST_FWDEVADDR = 1 -> first send the periph device address * I2C_INST_FWBYTESCOUNT = 1 -> 1 byte in FWBYTES (register address) * I2C_INST_REPEATEDSTART = 1 -> send start bit following write - * I2C_INST_RWDEVADDR = 1 -> send slave address in read mode - * I2C_INST_RWDEVADDR_RWB = 1 -> read bytes following slave address + * I2C_INST_RWDEVADDR = 1 -> send periph address in read mode + * I2C_INST_RWDEVADDR_RWB = 1 -> read bytes following periph address * I2C_INST_FINALNA = 1 -> ACK read bytes, NACK last byte read * I2C_INST_FINALSTOP = 1 -> send stop bit - * I2C_INST_DEVADDRVAL = slave address + * I2C_INST_DEVADDRVAL = periph address * I2C_FWBYTES[b7:b0] = out[0] -> register address byte * * Once transaction is complete: @@ -254,7 +254,7 @@ static uint32_t i2cc_create_inst(int periph_addr_flags, int is_write, if (flags & I2C_XFER_START) { /* - * Start sequence will have to be issued, slave address needs + * Start sequence will have to be issued, periph address needs * to be included. */ inst |= INST_START; diff --git a/chip/g/i2cp.c b/chip/g/i2cp.c index 801ce05968..09d7235be6 100644 --- a/chip/g/i2cp.c +++ b/chip/g/i2cp.c @@ -7,17 +7,17 @@ * This is a driver for the I2C peripheral (i2cp) of the g chip. * * The driver has two register files, 64 bytes each, one for storing data - * received from the master, and one for storing data to be transmitted to the - * master. Both files are accessed only as 4 byte quantities, so the driver - * must provide adaptation to concatenate messages with sizes not divisible by - * 4 and or not properly aligned. + * received from the controller, and one for storing data to be transmitted to + * the controller. Both files are accessed only as 4 byte quantities, so the + * driver must provide adaptation to concatenate messages with sizes not + * divisible by 4 and or not properly aligned. * - * The file holding data written by the master has associated with it a + * The file holding data written by the controller has associated with it a * register showing where the driver accessed the file last, comparing it * with its previous value tells the driver how many bytes recently written by - * the master are there. + * the controller are there. * - * The file holding data to be read by the master has a register associated + * The file holding data to be read by the controller has a register associated * with it showing where was the latest BIT the driver transmitted. * * The driver can generate interrupts on three different conditions: @@ -26,35 +26,35 @@ * - end of a write cycle * * Since this driver's major role is to serve as a TPM interface, it is safe - * to assume that the master will always write first, even when it needs to + * to assume that the controller will always write first, even when it needs to * read data from the device. * - * Each write or read access will be started by the master writing the one + * Each write or read access will be started by the controller writing the one * byte address of the TPM register to access. * - * If the master needs to read this register, the originating write + * If the controller needs to read this register, the originating write * transaction will be limited to a single byte payload, a read transaction * would follow immediately. * - * If the master needs to write into this register, the data to be written + * If the controller needs to write into this register, the data to be written * will be included in the same i2c transaction immediately following the one * byte register address. * * This protocol allows to keep the driver simple: the only interrupt the * driver enables is the 'end a write cycle'. The number of bytes received - * from the master gives the callback function a hint as of what the master - * intention is, to read or to write. + * from the controller gives the callback function a hint as of what the + * controller intention is, to read or to write. * * In both cases the same callback function is called. On write accesses the * callback function converts the data as necessary and passes it to the TPM. * On read accesses the callback function retrieves data from the TPM and puts - * it into the read register file to be available to the master to retrieve in - * the following read access. In both cases the callback function completes + * it into the read register file to be available to the controller to retrieve + * in the following read access. In both cases the callback function completes * processing on the invoking interrupt context. * * The driver API consists of two functions, one to register the callback to - * process interrupts, another one - to add a byte to the master read register - * file. See the accompanying .h file for details. + * process interrupts, another one - to add a byte to the congroller read + * register file. See the accompanying .h file for details. * * TODO: * - figure out flow control - clock stretching can be challenging with this @@ -87,19 +87,19 @@ static wr_complete_handler_f write_complete_handler_; static uint8_t i2cp_buffer[REGISTER_FILE_SIZE]; /* - * Pointer where the CPU stopped retrieving the write data sent by the master - * last time the write access was processed. + * Pointer where the CPU stopped retrieving the write data sent by the + * controller last time the write access was processed. */ static uint16_t last_write_pointer; /* - * Pointer where the CPU stopped writing data for the master to read last time - * the read data was prepared. + * Pointer where the CPU stopped writing data for the controller to read last + * time the read data was prepared. */ static uint16_t last_read_pointer; /* - * Keep track number of times the "hosed slave" condition was encountered. + * Keep track number of times the "hosed periph" condition was encountered. */ static uint16_t i2cp_read_recovery_count; static uint16_t i2cp_sda_low_count; @@ -139,13 +139,13 @@ static void i2cp_init(void) GWRITE(I2CS, READ_PTR, 0); GWRITE(I2CS, WRITE_PTR, 0); - /* Just in case we were wedged and the master starts with a read. */ + /* Just in case we were wedged and the controller starts with a read. */ *GREG32_ADDR(I2CS, READ_BUFFER0) = ~0; /* Enable I2CP interrupt */ GWRITE_FIELD(I2CS, INT_ENABLE, INTR_WRITE_COMPLETE, 1); - /* Slave address is hardcoded to 0x50. */ + /* periph address is hardcoded to 0x50. */ GWRITE(I2CS, SLAVE_DEVADDRVAL, 0x50); } @@ -176,7 +176,7 @@ DECLARE_DEFERRED(poll_read_state); * If the poller happened to run during time 3 and time 4 while SDA was low, * i2cp_sda_low_count would = 2. This is not considered an error case. If we * were to see a third low value before time 5, we can assume the bus is stuck, - * or the master performed multiple reads between writes (which is not + * or the controller performed multiple reads between writes (which is not * expected). * * If we were to enable the read complete interrupt and use it to clear @@ -199,7 +199,7 @@ DECLARE_DEFERRED(poll_read_state); * Restart the i2cp driver if the driver gets stuck transmitting a 0 on * SDA. * - * This can happen anytime the i2cp driver has control of SDA and the master + * This can happen anytime the i2cp driver has control of SDA and the controller * happens to fail and stops clocking. * * For example when the i2cp driver is: @@ -207,15 +207,15 @@ DECLARE_DEFERRED(poll_read_state); * 2) Transmitting an ACK for a write transaction. * 3) Transmitting byte data for a read transaction. * - * The reason this is problematic is because the master can't recover the bus - * by issuing a new transaction. A start condition is defined as the master - * pulling SDA low while SCL is high. The master can only initiate the start - * condition when the bus is free (i.e., SDA is high), otherwise the master + * The reason this is problematic is because the i2cc can't recover the bus + * by issuing a new transaction. A start condition is defined as the i2cc + * pulling SDA low while SCL is high. The i2cc can only initiate the start + * condition when the bus is free (i.e., SDA is high), otherwise the i2cc * thinks that it lost arbitration. * * We don't have to deal with the scenario where the driver gets stuck - * transmitting a 1 on SDA since the master can recover the bus by issuing a - * normal transaction. The master will at minimum clock 9 times on any + * transmitting a 1 on SDA since the controller can recover the bus by issuing a + * normal transaction. The controller will at minimum clock 9 times on any * transaction. This is enough for the slave to complete its current operation * and NACK. */ @@ -226,16 +226,16 @@ static void poll_read_state(void) * When the AP is off, the SDA line might drop low since the * pull ups might not be powered. * - * If the AP is on, the bus is either idle, the master has + * If the AP is on, the bus is either idle, the controller has * stopped clocking while SDA is high, or we have polled in the * middle of a transaction where SDA happens to be high. */ i2cp_sda_low_count = 0; } else { /* - * The master has stopped clocking while the slave is holding - * SDA low, or we have polled in the middle of a transaction - * where SDA happens to be low. + * The controller has stopped clocking while the periph is + * holding SDA low, or we have polled in the middle of a + * transaction where SDA happens to be low. */ i2cp_sda_low_count++; @@ -280,7 +280,7 @@ void __attribute__((used)) _i2cp_write_complete_int(void) uint16_t bytes_processed; uint32_t word_in_value = 0; - /* How many bytes has the master just written. */ + /* How many bytes has the controller just written. */ bytes_written = ((uint16_t)GREAD(I2CS, WRITE_PTR) - last_write_pointer) & REGISTER_FILE_MASK; @@ -294,7 +294,7 @@ void __attribute__((used)) _i2cp_write_complete_int(void) while (bytes_written != bytes_processed) { /* * This loop iterates over bytes retrieved from the - * master write register file in 4 byte quantities. + * controller write register file in 4 byte quantities. * Each time the ever incrementing last_write_pointer * is aligned at 4 bytes, a new value needs to be * retrieved from the next register, indexed by @@ -321,7 +321,7 @@ void __attribute__((used)) _i2cp_write_complete_int(void) write_complete_handler_(i2cp_buffer, bytes_processed); } - /* The transaction is complete so the slave has released SDA. */ + /* The transaction is complete so the periph has released SDA. */ i2cp_sda_low_count = 0; /* diff --git a/chip/g/i2cp.h b/chip/g/i2cp.h index 5ab7286fc7..f7c5d283dd 100644 --- a/chip/g/i2cp.h +++ b/chip/g/i2cp.h @@ -19,13 +19,13 @@ typedef void (*wr_complete_handler_f)(void *i2cp_data, size_t i2cp_data_size); int i2cp_register_write_complete_handler(wr_complete_handler_f wc_handler); /* - * Post a byte for the master to read. Blend the byte into the appropriate - * 4byte register of the master read register file. + * Post a byte for the controller to read. Blend the byte into the appropriate + * 4byte register of the controller read register file. */ void i2cp_post_read_data(uint8_t byte_to_read); /* - * Configure the pinmux registers required to connect the I2CP interface. This + * Configure the pinmux registers required to connect the I2CP driver. This * function is board specific and so it exists in the associated board.c file. */ void i2cp_set_pinmux(void); @@ -41,7 +41,7 @@ void i2cp_set_pinmux(void); size_t i2cp_zero_read_fifo_buffer_depth(void); /* - * Write buffer of data into the I2CS HW read fifo. The function will operate a + * Write buffer of data into the I2CP HW read fifo. The function will operate a * byte at a time until the fifo write pointer is word aligned. Then it will * consume all remaining words of input data. There is another stage to handle * any excess bytes. The efficiency benefits relative the byte at a time @@ -51,10 +51,10 @@ size_t i2cp_zero_read_fifo_buffer_depth(void); void i2cp_post_read_fill_fifo(uint8_t *buffer, size_t len); /* - * Provide upper layers with information with the I2CP interface + * Provide upper layers with information with the I2CP driver * status/statistics. The only piece of information currently provided is the - * counter of "hosed" i2c interface occurences, where i2c clocking stopped - * while slave was transmitting a zero. + * counter of "hosed" i2c driver occurences, where i2c clocking stopped + * while periph was transmitting a zero. */ struct i2cp_status { uint16_t read_recovery_count; diff --git a/chip/g/ite_flash.c b/chip/g/ite_flash.c index b4e1699a08..d010e7beca 100644 --- a/chip/g/ite_flash.c +++ b/chip/g/ite_flash.c @@ -57,9 +57,9 @@ void generate_ite_sync(void) (both_one >> 8) * 4); /* - * Let's take over the i2c master pins. Connect pads DIOB0(aka i2c - * scl) to gpio0.12 and DIOB1(aka sda) to gpio0.13. I2c master - * controller is disconnected from the pads. + * Let's take over the i2c controller pins. Connect pads DIOB0(aka i2c + * scl) to gpio0.12 and DIOB1(aka sda) to gpio0.13. I2c controller + * is disconnected from the pads. */ REG32(GBASE(PINMUX) + GOFFSET(PINMUX, DIOB0_SEL)) = GC_PINMUX_GPIO0_GPIO12_SEL; @@ -86,10 +86,7 @@ void generate_ite_sync(void) interrupt_enable(); - /* - * Restore I2C configuration, re-attach i2c master controller to the - * pads. - */ + /* Restore I2C configuration, re-attach i2c controller to the pads. */ REG32(GBASE(PINMUX) + GOFFSET(PINMUX, DIOB0_SEL)) = GC_PINMUX_I2C0_SCL_SEL; REG32(GBASE(PINMUX) + GOFFSET(PINMUX, DIOB1_SEL)) = diff --git a/chip/lm4/i2c.c b/chip/lm4/i2c.c index 2392182415..9481d66e66 100644 --- a/chip/lm4/i2c.c +++ b/chip/lm4/i2c.c @@ -40,7 +40,7 @@ /* * Minimum delay between resetting the port or sending a stop condition, and - * when the port can be expected to be back in an idle state (and the slave + * when the port can be expected to be back in an idle state (and the periph * has had long enough to see the start/stop condition edges). * * 500 us = 50 clocks at 100 KHz bus speed. This has been experimentally @@ -103,7 +103,7 @@ int i2c_do_work(int port) /* * Error after starting; abort transfer. Ignore errors at * start because arbitration and timeout errors are taken care - * of in chip_i2c_xfer(), and slave ack failures will + * of in chip_i2c_xfer(), and periph ack failures will * automatically clear once we send a start condition. */ pd->err = EC_ERROR_UNKNOWN; @@ -212,13 +212,13 @@ int chip_i2c_xfer(const int port, const uint16_t periph_addr_flags, LM4_I2C_MTPR(port) = tpr; /* - * We don't know what edges the slave saw, so sleep long enough - * that the slave will see the new start condition below. + * We don't know what edges the periph saw, so sleep long enough + * that the periph will see the new start condition below. */ usleep(I2C_IDLE_US); } - /* Set slave address for transmit */ + /* Set periph address for transmit */ LM4_I2C_MSA(port) = (I2C_GET_ADDR(periph_addr_flags) << 1) & 0xff; /* Enable interrupts */ @@ -358,7 +358,7 @@ void i2c_init(void) /* Configure GPIOs */ gpio_config_module(MODULE_I2C, 1); - /* Initialize ports as master, with interrupts enabled */ + /* Initialize ports as controller, with interrupts enabled */ for (i = 0; i < i2c_ports_used; i++) LM4_I2C_MCR(i2c_ports[i].port) = 0x10; |