diff options
| author | Anton Staaf <robotboy@chromium.org> | 2015-07-22 09:11:46 -0700 |
|---|---|---|
| committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-07-27 19:30:44 +0000 |
| commit | 4626177c3b055fdbab6344065d9b335a40ea1c1e (patch) | |
| tree | a704de5752df739253b0a4b2dcb350075087a1eb /chip | |
| parent | 3e9bd8027c9317dbf12cdd59d735efd47fb3f1f4 (diff) | |
| download | chrome-ec-4626177c3b055fdbab6344065d9b335a40ea1c1e.tar.gz | |
Atomic: Mark the modified uint32_t volatile
The atomic_* functions are often used in contexts where the data they
will operate on are volatile (due to being shared between tasks or a
task and an interrupt handler). Adding volatile here makes using the
atomic_* functions a little easier in those cases and removes a cast
from the call sites (which could be obscuring a bug, if for instance
the variable was modified to be a uint16_t).
Signed-off-by: Anton Staaf <robotboy@chromium.org>
BRANCH=None
BUG=None
TEST=make buildall -j
Change-Id: I71356eb3cf2c0506df38532eee767c7d78f9240e
Reviewed-on: https://chromium-review.googlesource.com/287516
Trybot-Ready: Anton Staaf <robotboy@chromium.org>
Tested-by: Anton Staaf <robotboy@chromium.org>
Reviewed-by: Vincent Palatin <vpalatin@chromium.org>
Commit-Queue: Anton Staaf <robotboy@chromium.org>
Diffstat (limited to 'chip')
| -rw-r--r-- | chip/stm32/usart_rx_interrupt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/chip/stm32/usart_rx_interrupt.c b/chip/stm32/usart_rx_interrupt.c index 6a46b3fb11..ea1b4a4c6a 100644 --- a/chip/stm32/usart_rx_interrupt.c +++ b/chip/stm32/usart_rx_interrupt.c @@ -31,7 +31,7 @@ static void usart_rx_interrupt_handler(struct usart_config const *config) byte = STM32_USART_RDR(base); if (!queue_add_unit(config->producer.queue, &byte)) - atomic_add((uint32_t *) &config->state->rx_dropped, 1); + atomic_add(&config->state->rx_dropped, 1); } struct usart_rx const usart_rx_interrupt = { |