summaryrefslogtreecommitdiff
path: root/chip
diff options
context:
space:
mode:
authorRandall Spangler <rspangler@chromium.org>2013-11-01 10:15:48 -0700
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2013-11-02 01:07:10 +0000
commit00682eb80fe159c1d037c721f2dd15c1be44bd12 (patch)
tree1a4365c129c6416a18e2198da5ea35c0829cb5da /chip
parent874effa445584c04909735b96e082cc9c5787883 (diff)
downloadchrome-ec-00682eb80fe159c1d037c721f2dd15c1be44bd12.tar.gz
cleanup: Still more TODO comments
More of same. Comment changes only; no code changes. BUG=chrome-os-partner:18343 BRANCH=none TEST=build all platforms; pass unit tests Change-Id: I8c42ed7d332cd9d461067e1aeac670855106cbcd Signed-off-by: Randall Spangler <rspangler@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/175405 Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Diffstat (limited to 'chip')
-rw-r--r--chip/host/uart.c13
-rw-r--r--chip/stm32/config-stm32l100.h12
-rw-r--r--chip/stm32/config-stm32l15x.h12
3 files changed, 20 insertions, 17 deletions
diff --git a/chip/host/uart.c b/chip/host/uart.c
index 770ea8c0ef..2a05fb686e 100644
--- a/chip/host/uart.c
+++ b/chip/host/uart.c
@@ -23,7 +23,10 @@ static int init_done;
static pthread_t input_thread;
#define INPUT_BUFFER_SIZE 16
-/* TODO: Guard these data with mutex lock when we have interrupt support. */
+/*
+ * TODO(crosbug.com/p/23804): Guard these data with mutex lock when we have
+ * interrupt support.
+ */
static int char_available;
static char cached_char_buf[INPUT_BUFFER_SIZE];
static struct queue cached_char = {
@@ -66,8 +69,8 @@ const char *test_get_captured_console(void)
static void trigger_interrupt(void)
{
/*
- * TODO: Check global interrupt status when we have
- * interrupt support.
+ * TODO(crosbug.com/p/23804): Check global interrupt status when we
+ * have interrupt support.
*/
if (!int_disabled) {
uart_process_input();
@@ -174,8 +177,8 @@ void *uart_monitor_stdin(void *d)
}
tcsetattr(0, TCSANOW, &org_settings);
/*
- * TODO: Trigger emulated interrupt when we have
- * interrupt support. Also, we will need a condition
+ * TODO(crosbug.com/p/23804): Trigger emulated interrupt when
+ * we have interrupt support. Also, we will need a condition
* variable to indicate the character has been read.
*/
trigger_interrupt();
diff --git a/chip/stm32/config-stm32l100.h b/chip/stm32/config-stm32l100.h
index e22518263a..2198f6dc0a 100644
--- a/chip/stm32/config-stm32l100.h
+++ b/chip/stm32/config-stm32l100.h
@@ -11,12 +11,12 @@
#define CONFIG_FLASH_ERASE_SIZE 0x0100 /* erase bank size */
/*
- * TODO(rspangler): Technically we can write in word-mode (4 bytes at a time),
- * but that's really slow, and older host interfaces which can't ask about the
- * ideal size would then end up writing in that mode instead of the faster page
- * mode. So lie about the write size for now. Once all software (flashrom,
- * u-boot, ectool) which cares has been updated to know about ver.1 of
- * EC_CMD_GET_FLASH_INFO, we can remove this workaround.
+ * TODO(crosbug.com/p/23805): Technically we can write in word-mode (4 bytes at
+ * a time), but that's really slow, and older host interfaces which can't ask
+ * about the ideal size would then end up writing in that mode instead of the
+ * faster page mode. So lie about the write size for now. Once all software
+ * (flashrom, u-boot, ectool) which cares has been updated to know about ver.1
+ * of EC_CMD_GET_FLASH_INFO, we can remove this workaround.
*/
#define CONFIG_FLASH_WRITE_SIZE 0x0080
diff --git a/chip/stm32/config-stm32l15x.h b/chip/stm32/config-stm32l15x.h
index eef90576d4..7d51ca1bda 100644
--- a/chip/stm32/config-stm32l15x.h
+++ b/chip/stm32/config-stm32l15x.h
@@ -11,12 +11,12 @@
#define CONFIG_FLASH_ERASE_SIZE 0x0100 /* erase bank size */
/*
- * TODO(rspangler): Technically we can write in word-mode (4 bytes at a time),
- * but that's really slow, and older host interfaces which can't ask about the
- * ideal size would then end up writing in that mode instead of the faster page
- * mode. So lie about the write size for now. Once all software (flashrom,
- * u-boot, ectool) which cares has been updated to know about ver.1 of
- * EC_CMD_GET_FLASH_INFO, we can remove this workaround.
+ * TODO(crosbug.com/p/23805): Technically we can write in word-mode (4 bytes at
+ * a time), but that's really slow, and older host interfaces which can't ask
+ * about the ideal size would then end up writing in that mode instead of the
+ * faster page mode. So lie about the write size for now. Once all software
+ * (flashrom, u-boot, ectool) which cares has been updated to know about ver.1
+ * of EC_CMD_GET_FLASH_INFO, we can remove this workaround.
*/
#define CONFIG_FLASH_WRITE_SIZE 0x0080