diff options
| author | Randall Spangler <rspangler@chromium.org> | 2013-10-24 15:50:53 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-10-25 01:32:31 +0000 |
| commit | c0fbbaefed2b82bacf4a202cda529658b5d6d058 (patch) | |
| tree | ac02af96277f61e4e5fafad65cb9d49c16297829 /chip | |
| parent | 870b7ebb788edd1adba70a330d6b0f8c66439849 (diff) | |
| download | chrome-ec-c0fbbaefed2b82bacf4a202cda529658b5d6d058.tar.gz | |
cleanup: comments in i2c modules
No code changes; just update comments with bug links
BUG=none
BRANCH=none
TEST=build all platforms
Change-Id: I8b845f9c43315b7db5a746a16c6618c3ee96979d
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/174614
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Diffstat (limited to 'chip')
| -rw-r--r-- | chip/stm32/i2c-stm32f.c | 8 | ||||
| -rw-r--r-- | chip/stm32/i2c-stm32l.c | 12 |
2 files changed, 9 insertions, 11 deletions
diff --git a/chip/stm32/i2c-stm32f.c b/chip/stm32/i2c-stm32f.c index 1809b7cd3f..59f957279d 100644 --- a/chip/stm32/i2c-stm32f.c +++ b/chip/stm32/i2c-stm32f.c @@ -818,7 +818,7 @@ int i2c_xfer(int port, int slave_addr, const uint8_t *out, int out_bytes, { int rv; - /* TODO: support start/stop flags */ + /* TODO(crosbug.com/p/23569): support start/stop flags */ ASSERT(out || !out_bytes); ASSERT(in || !in_bytes); @@ -866,9 +866,9 @@ int i2c_read_string(int port, int slave_addr, int offset, uint8_t *data, uint8_t reg, block_length; /* - * TODO: when i2c_xfer() supports start/stop bits, won't need a temp - * buffer, and this code can merge with the LM4 implementation and - * move to i2c_common.c. + * TODO(crosbug.com/p/23569): when i2c_xfer() supports start/stop bits, + * won't need a temp buffer, and this code can merge with the LM4 + * implementation and move to i2c_common.c. */ uint8_t buffer[SMBUS_MAX_BLOCK + 1]; diff --git a/chip/stm32/i2c-stm32l.c b/chip/stm32/i2c-stm32l.c index 5b4f05fed5..27f6eb92bb 100644 --- a/chip/stm32/i2c-stm32l.c +++ b/chip/stm32/i2c-stm32l.c @@ -256,8 +256,6 @@ static void i2c_init_port(const struct i2c_port_t *p, int force_unwedge) /* Set up initial bus frequencies */ i2c_set_freq_port(p); - - /* TODO: enable interrupts using I2C_CR2 bits 8,9 */ } /*****************************************************************************/ @@ -278,8 +276,8 @@ int i2c_xfer(int port, int slave_addr, const uint8_t *out, int out_bytes, /* * Clear status * - * TODO: should check for any leftover error status, and reset the - * port if present. + * TODO(crosbug.com/p/29314): should check for any leftover error + * status, and reset the port if present. */ STM32_I2C_SR1(port) = 0; @@ -457,9 +455,9 @@ int i2c_read_string(int port, int slave_addr, int offset, uint8_t *data, uint8_t reg, block_length; /* - * TODO: when i2c_xfer() supports start/stop bits, won't need a temp - * buffer, and this code can merge with the LM4 implementation and - * move to i2c_common.c. + * TODO(crosbug.com/p/23569): When i2c_xfer() supports start/stop bits + * on all platforms, won't need a temp buffer, and this code can merge + * with the LM4 implementation and move to i2c_common.c. */ uint8_t buffer[SMBUS_MAX_BLOCK + 1]; |