diff options
author | Vadim Bendebury <vbendeb@chromium.org> | 2015-07-15 19:07:30 -0700 |
---|---|---|
committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-07-17 00:07:38 +0000 |
commit | 53a2bbace35a1c55f595b9f052b627a7339c74c5 (patch) | |
tree | 61a59ec057e5ad779977b7aa8883717806dfe5fa /chip | |
parent | 79ff743aaa59b749b9ec741bc88a4fe88e5d4ed6 (diff) | |
download | chrome-ec-53a2bbace35a1c55f595b9f052b627a7339c74c5.tar.gz |
util: small config_option_check.py improvements
As of now this check results in false positives, for instance
'CONFIG_' found in the comments results in an error report.
This patch makes the script a bit more robust:
- consider only those options mentioned in include/config.h as
explicitly defined or undefined.
- do not scan include/config.h for new added CONFIG_ options
- ignore comments in .mk files
Ideally the script should be scanning only added lines of code and
much smarter about what should be considered a comment and what files
should be examined.
BRANCH=none
BUG=chromium:510672
TEST=the false positives triggered by comments in various build.mk
files are gone now. Adding an undescribed CONFIG_xxx text still
triggers the error.
Change-Id: Ib9858775bcd9899dec629682a1c7965e7c2fec96
Signed-off-by: Vadim Bendebury <vbendeb@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/285926
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Diffstat (limited to 'chip')
0 files changed, 0 insertions, 0 deletions