diff options
| author | Randall Spangler <rspangler@chromium.org> | 2014-01-07 11:16:12 -0800 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-01-08 02:19:33 +0000 |
| commit | 7964fa2bdc108efb20b0ce3b7dc4a161e951c28a (patch) | |
| tree | 64e3892a900c0ecc18943b6a7e630d0c38ef7e57 /chip | |
| parent | 59602b41e834155cb79125063dc41c7e1e259986 (diff) | |
| download | chrome-ec-7964fa2bdc108efb20b0ce3b7dc4a161e951c28a.tar.gz | |
Remove duplicate KBD_IRQ_L signals
The SERIRQ signal will now be high-Z on the EC, which removes a
leakage path. This requires the BIOS to use PM3 for its keyboard IRQ.
BUG=chrome-os-partner:24424
BRANCH=rambi
TEST=boot system; keyboard still works
Change-Id: I0acf425125ced11a9ef6da58ee49979b83c92d5c
Signed-off-by: Randall Spangler <rspangler@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/181718
Diffstat (limited to 'chip')
| -rw-r--r-- | chip/lm4/lpc.c | 12 |
1 files changed, 0 insertions, 12 deletions
diff --git a/chip/lm4/lpc.c b/chip/lm4/lpc.c index 63c6e9fece..aa15e1fbfe 100644 --- a/chip/lm4/lpc.c +++ b/chip/lm4/lpc.c @@ -88,20 +88,8 @@ static void keyboard_irq_assert(void) { /* Negative edge-triggered keyboard interrupt. */ gpio_set_level(CONFIG_KEYBOARD_IRQ_GPIO, 0); -#ifdef BOARD_RAMBI - /* - * TODO(crosbug.com/p/24424): Remove duplicate IRQ output when we - * finish transitioning from proto 1.5 to proto 2.0. - */ - gpio_set_level(GPIO_KBD_IRQ_NEW_L, 0); -#endif - wait_irq_sent(); - gpio_set_level(CONFIG_KEYBOARD_IRQ_GPIO, 1); -#ifdef BOARD_RAMBI - gpio_set_level(GPIO_KBD_IRQ_NEW_L, 1); -#endif } #else static void wait_send_serirq(uint32_t lpcirqctl) |