diff options
| author | Tom Hughes <tomhughes@chromium.org> | 2021-10-25 18:15:03 +0000 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2021-10-26 17:29:30 +0000 |
| commit | 20af49a170c2c07ba15173ecd9c9a53e939b257c (patch) | |
| tree | cd0d431416c04a00fd390b190d1355dfbd88152c /common/acpi.c | |
| parent | 71865096d3945f59aec48c784d0db47aa53e53cc (diff) | |
| download | chrome-ec-20af49a170c2c07ba15173ecd9c9a53e939b257c.tar.gz | |
common/acpi: Disable clang warning
When building with clang, it warns:
common/acpi.c:138:11: error: result of comparison of constant 256 with
expression of type 'uint8_t' (aka 'unsigned char') is always false
[-Werror,-Wtautological-constant-out-of-range-compare]
addr >= EC_ACPI_MEM_MAPPED_BEGIN + EC_ACPI_MEM_MAPPED_SIZE) {
~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
It doesn't hurt to leave the check as-is. The values of
EC_ACPI_MEM_MAPPED_BEGIN + EC_ACPI_MEM_MAPPED_SIZE may not be greater
than or equal to 255 on every board.
BRANCH=none
BUG=b:172020503
TEST=CC=clang make BOARD=voema
TEST=make buildall -j
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Change-Id: Ibb27421957e99f2f636331fbaa51dab6fa768744
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3243009
Reviewed-by: Paul Fagerburg <pfagerburg@chromium.org>
Diffstat (limited to 'common/acpi.c')
| -rw-r--r-- | common/acpi.c | 8 |
1 files changed, 8 insertions, 0 deletions
diff --git a/common/acpi.c b/common/acpi.c index d697eb7cd9..6717732e06 100644 --- a/common/acpi.c +++ b/common/acpi.c @@ -133,6 +133,10 @@ static int acpi_read(uint8_t addr) uint8_t *memmap_addr = (uint8_t *)(lpc_get_memmap_range() + addr - EC_ACPI_MEM_MAPPED_BEGIN); +#ifdef __clang__ +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wtautological-constant-out-of-range-compare" +#endif /* __clang__ */ /* Check for out-of-range read. */ if (addr < EC_ACPI_MEM_MAPPED_BEGIN || addr >= EC_ACPI_MEM_MAPPED_BEGIN + EC_ACPI_MEM_MAPPED_SIZE) { @@ -140,6 +144,10 @@ static int acpi_read(uint8_t addr) acpi_addr); return 0xff; } +#ifdef __clang__ +#pragma clang diagnostic pop +#endif /* __clang__ */ + /* Read from cache if enabled (burst mode). */ if (acpi_read_cache.enabled) { |