diff options
| author | Jack Rosenthal <jrosenth@chromium.org> | 2020-02-21 10:21:10 -0700 |
|---|---|---|
| committer | Chromeos LUCI <chromeos-scoped@luci-project-accounts.iam.gserviceaccount.com> | 2022-08-26 19:16:12 +0000 |
| commit | 32c80cad1ed85114adc2981e7a169cc747ab6b88 (patch) | |
| tree | 0b96a404ba3dd7131c160c391227a247b32fb559 /common/ap_ro_integrity_check.c | |
| parent | a8e2aabdddbc014d24b70821a45ed739d89afd25 (diff) | |
| download | chrome-ec-32c80cad1ed85114adc2981e7a169cc747ab6b88.tar.gz | |
util: convert config_option_check.py to Python 3
The main fixes that were needed were:
* Use utf-8 encoding from git subprocess.
* Don't use 'is' to compare string equality (Python does not guarantee
interning of strings). For the parser state, the string comparison
was removed by changing this to an Enum, since we have Python 3
anyway.
BUG=chromium:1031705
TEST=create commit with invalid config options and run script, notice
the script points them out and exits 1, then test without that
commit, no output and exit 0.
Change-Id: I1113e063f747f0207c4b59a74f4e4a06bbcd5fcd
Signed-off-by: Jack Rosenthal <jrosenth@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/2068520
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
(cherry picked from commit a9666e310606cbd1a54d32fa0cb200f16cf1d451)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/3858397
Tested-by: Mary Ruthven <mruthven@chromium.org>
Auto-Submit: Mary Ruthven <mruthven@chromium.org>
Diffstat (limited to 'common/ap_ro_integrity_check.c')
0 files changed, 0 insertions, 0 deletions