diff options
| author | Tom Hughes <tomhughes@chromium.org> | 2019-09-20 10:04:44 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-10-02 10:19:57 +0000 |
| commit | 83d793839479a6f3414dbf51c00536aff65618f3 (patch) | |
| tree | 41047552e73878fad5ddbc4126d59a52643b041f /common/audio_codec_i2s_rx.c | |
| parent | 4e692f29e3e5af6b85df472e4c4f936c6f461cb9 (diff) | |
| download | chrome-ec-83d793839479a6f3414dbf51c00536aff65618f3.tar.gz | |
host_command: Change host command return value to enum ec_status
If the host command handler callback function returns an int, it's easy
to accidentally mix up the enum ec_error_list and enum ec_status types.
The host commands always expect an enum ec_status type, so we change the
return value to be of that explicit type. Compilation will then fail if
you accidentally try to return an enum ec_error_list value.
Ran the following commands and then manually fixed up a few remaining
instances that were not caught:
git grep --name-only 'static int .*(struct host_cmd_handler_args \*args)' |\
xargs sed -i 's#static int \(.*\)(struct host_cmd_handler_args \*args)#\
static enum ec_status \1(struct host_cmd_handler_args \*args)##'
git grep --name-only 'int .*(struct host_cmd_handler_args \*args)' |\
xargs sed -i 's#int \(.*\)(struct host_cmd_handler_args \*args)#\
enum ec_status \1(struct host_cmd_handler_args \*args)##'
BRANCH=none
BUG=chromium:1004831
TEST=make buildall -j
Cq-Depend: chrome-internal:1872675
Change-Id: Id93df9387ac53d016a1594dba86c6642babbfd1e
Signed-off-by: Tom Hughes <tomhughes@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1816865
Reviewed-by: Daisuke Nojiri <dnojiri@chromium.org>
Reviewed-by: Jack Rosenthal <jrosenth@chromium.org>
Diffstat (limited to 'common/audio_codec_i2s_rx.c')
| -rw-r--r-- | common/audio_codec_i2s_rx.c | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/common/audio_codec_i2s_rx.c b/common/audio_codec_i2s_rx.c index 301612b086..b5c3be4926 100644 --- a/common/audio_codec_i2s_rx.c +++ b/common/audio_codec_i2s_rx.c @@ -12,7 +12,7 @@ static uint8_t i2s_rx_enabled; -static int i2s_rx_enable(struct host_cmd_handler_args *args) +static enum ec_status i2s_rx_enable(struct host_cmd_handler_args *args) { if (i2s_rx_enabled) return EC_RES_BUSY; @@ -25,7 +25,7 @@ static int i2s_rx_enable(struct host_cmd_handler_args *args) return EC_RES_SUCCESS; } -static int i2s_rx_disable(struct host_cmd_handler_args *args) +static enum ec_status i2s_rx_disable(struct host_cmd_handler_args *args) { if (!i2s_rx_enabled) return EC_RES_BUSY; @@ -38,7 +38,8 @@ static int i2s_rx_disable(struct host_cmd_handler_args *args) return EC_RES_SUCCESS; } -static int i2s_rx_set_sample_depth(struct host_cmd_handler_args *args) +static enum ec_status +i2s_rx_set_sample_depth(struct host_cmd_handler_args *args) { const struct ec_param_ec_codec_i2s_rx *p = args->params; const uint8_t depth = p->set_sample_depth_param.depth; @@ -54,7 +55,7 @@ static int i2s_rx_set_sample_depth(struct host_cmd_handler_args *args) return EC_RES_SUCCESS; } -static int i2s_rx_set_daifmt(struct host_cmd_handler_args *args) +static enum ec_status i2s_rx_set_daifmt(struct host_cmd_handler_args *args) { const struct ec_param_ec_codec_i2s_rx *p = args->params; const uint8_t daifmt = p->set_daifmt_param.daifmt; @@ -70,7 +71,7 @@ static int i2s_rx_set_daifmt(struct host_cmd_handler_args *args) return EC_RES_SUCCESS; } -static int i2s_rx_set_bclk(struct host_cmd_handler_args *args) +static enum ec_status i2s_rx_set_bclk(struct host_cmd_handler_args *args) { const struct ec_param_ec_codec_i2s_rx *p = args->params; @@ -102,7 +103,7 @@ static char *strcmd[] = { BUILD_ASSERT(ARRAY_SIZE(sub_cmds) == ARRAY_SIZE(strcmd)); #endif -static int i2s_rx_host_command(struct host_cmd_handler_args *args) +static enum ec_status i2s_rx_host_command(struct host_cmd_handler_args *args) { const struct ec_param_ec_codec_i2s_rx *p = args->params; |