diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2016-08-22 17:55:12 -0700 |
|---|---|---|
| committer | Bill Richardson <wfrichar@chromium.org> | 2016-08-24 16:30:10 +0000 |
| commit | bb15561db56728b83ee7fe35e534da7577a7729d (patch) | |
| tree | e586ee3b18c8fda464da38b42a06845f0d7f6786 /common/btle_hci_controller.c | |
| parent | f322e32a3ec052be3f0c226145448fed63aa7ef9 (diff) | |
| download | chrome-ec-bb15561db56728b83ee7fe35e534da7577a7729d.tar.gz | |
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.
We're never going to use this, let's just get rid of it.
BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware
Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.
Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'common/btle_hci_controller.c')
| -rw-r--r-- | common/btle_hci_controller.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/common/btle_hci_controller.c b/common/btle_hci_controller.c index 49b189ce66..3d4076b073 100644 --- a/common/btle_hci_controller.c +++ b/common/btle_hci_controller.c @@ -509,8 +509,7 @@ static int command_ble_hci_cmd(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(ble_hci_cmd, command_ble_hci_cmd, "opcode len uint32 uint32 uint32... (little endian)", - "Send an hci command of length len", - NULL); + "Send an hci command of length len"); static int command_hcitool(int argc, char **argv) { @@ -550,8 +549,7 @@ static int command_hcitool(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(hcitool, command_hcitool, "cmd ogf ocf b0 b1 b2 b3... or lcmd opcode len uint32.. (little endian)", - "Send an hci command of length len", - NULL); + "Send an hci command of length len"); static int command_ble_hci_acl(int argc, char **argv) { @@ -596,8 +594,7 @@ static int command_ble_hci_acl(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(ble_hci_acl, command_ble_hci_acl, "hdr len uint32 uint32 uint32... (little endian)", - "Send hci acl data of length len", - NULL); + "Send hci acl data of length len"); static int command_ble_hci_adv(int argc, char **argv) { @@ -666,7 +663,6 @@ static int command_ble_hci_adv(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(ble_hci_adv, command_ble_hci_adv, "adv [params=0] [scan_rsp=0]", - "Use pre-defined parameters to start advertising", - NULL); + "Use pre-defined parameters to start advertising"); #endif /* CONFIG_BLUETOOTH_HCI_DEBUG */ |