diff options
| author | Anton Staaf <robotboy@chromium.org> | 2016-03-23 12:45:28 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2016-04-18 17:32:40 -0700 |
| commit | 068cd0850684ee28a5a514e5a270edce2edb3979 (patch) | |
| tree | e84f2316e37baa72f1c9611e665749d91a3ce8fd /common/button.c | |
| parent | 1e7c280491232110e1006d545f9a61ca05d469d5 (diff) | |
| download | chrome-ec-068cd0850684ee28a5a514e5a270edce2edb3979.tar.gz | |
Deferred: Use deferred_data instead of function pointer
Previously calls to hook_call_deferred were passed the function to call,
which was then looked up in the .rodata.deferred section with a linear
search. This linear search can be replaced with a subtract by passing
the pointer to the deferred_data object created when DECLARE_DEFERRED
was invoked.
Signed-off-by: Anton Staaf <robotboy@chromium.org>
BRANCH=None
BUG=None
CQ-DEPEND=CL:*255812
TEST=make buildall -j
Change-Id: I951dd1541302875b102dd086154cf05591694440
Reviewed-on: https://chromium-review.googlesource.com/334315
Commit-Ready: Bill Richardson <wfrichar@chromium.org>
Tested-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-by: Bill Richardson <wfrichar@chromium.org>
Diffstat (limited to 'common/button.c')
| -rw-r--r-- | common/button.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/common/button.c b/common/button.c index 89e6d409e2..38f5a61403 100644 --- a/common/button.c +++ b/common/button.c @@ -57,6 +57,10 @@ DECLARE_HOOK(HOOK_INIT, button_init, HOOK_PRIO_DEFAULT); /* * Handle debounced button changing state. */ + +static void button_change_deferred(void); +DECLARE_DEFERRED(button_change_deferred); + static void button_change_deferred(void) { int i; @@ -99,11 +103,10 @@ static void button_change_deferred(void) if (soonest_debounce_time != 0) { next_deferred_time = soonest_debounce_time; - hook_call_deferred(button_change_deferred, + hook_call_deferred(&button_change_deferred_data, next_deferred_time - time_now); } } -DECLARE_DEFERRED(button_change_deferred); /* * Handle a button interrupt. @@ -121,7 +124,7 @@ void button_interrupt(enum gpio_signal signal) if (next_deferred_time <= time_now || next_deferred_time > state[i].debounce_time) { next_deferred_time = state[i].debounce_time; - hook_call_deferred(button_change_deferred, + hook_call_deferred(&button_change_deferred_data, next_deferred_time - time_now); } break; |