diff options
author | Shawn Nematbakhsh <shawnn@chromium.org> | 2015-02-11 19:32:15 -0800 |
---|---|---|
committer | ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> | 2015-02-12 23:08:45 +0000 |
commit | 96536de3f4c2b942b5c40ac18a2a42d282f98dbf (patch) | |
tree | 3c63f70b667905fc65a66445553779ae71e5662e /common/charge_manager.c | |
parent | abbcf4152946c2a086bde85a2f56db0bbf54996f (diff) | |
download | chrome-ec-96536de3f4c2b942b5c40ac18a2a42d282f98dbf.tar.gz |
pd_log: Add command to request PD MCU to write a log
When we find that charging is in a wedged state, we may wish to write a
PD log entry, but the PD MCU cannot detect such a state on its own.
Therefore, add a new command to ask the PD MCU to write a log of a given
type, and add a new board-specific custom log event.
BUG=chrome-os-partner:36668
TEST=Manual on samus:
./ectool --dev=1 pdwritelog charge 0
./ectool --dev=1 pdwritelog charge 1
./ectool --dev=1 pdwritelog 1 0
./ectool --dev=1 pdwritelog 2 0
./ectool --dev=1 pdlog
Verify log output matches expectation:
2015-02-12 11:12:49.290 P0 SRC
2015-02-12 11:12:49.296 P1 SNK Charger PD 20286mV max 20000mV / 3000mA
2015-02-12 11:12:49.303 P0 New connection
2015-02-12 11:12:49.310 P0 Board-custom event
--- END OF LOG --
Also, verify kernel logging of wedged event:
[ 181.378420] PDLOG 2015/02/12 19:13:44.019 P0 Event 02 (0000) []
Also, trigger wedged state on Samus and verify log entry is written.
BRANCH=Samus
Change-Id: I55c7c839cf8300fcd3931dccdaaf16c1065e31a8
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/248981
Reviewed-by: Alec Berg <alecaberg@chromium.org>
Diffstat (limited to 'common/charge_manager.c')
-rw-r--r-- | common/charge_manager.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/common/charge_manager.c b/common/charge_manager.c index 35a570d2e6..bf93724cbd 100644 --- a/common/charge_manager.c +++ b/common/charge_manager.c @@ -199,6 +199,9 @@ void charge_manager_save_log(int port) uint16_t flags = 0; struct ec_response_usb_pd_power_info pinfo; + if (port < 0 || port >= PD_PORT_COUNT) + return; + save_log[port] = 0; charge_manager_fill_power_info(port, &pinfo); |