diff options
| author | Bill Richardson <wfrichar@chromium.org> | 2016-08-22 17:55:12 -0700 |
|---|---|---|
| committer | Bill Richardson <wfrichar@chromium.org> | 2016-08-24 16:30:10 +0000 |
| commit | bb15561db56728b83ee7fe35e534da7577a7729d (patch) | |
| tree | e586ee3b18c8fda464da38b42a06845f0d7f6786 /common/charge_manager.c | |
| parent | f322e32a3ec052be3f0c226145448fed63aa7ef9 (diff) | |
| download | chrome-ec-bb15561db56728b83ee7fe35e534da7577a7729d.tar.gz | |
cleanup: DECLARE_CONSOLE_COMMAND only needs 4 args
Since pretty much always, we've declared console commands to take
a "longhelp" argument with detailed explanations of what the
command does. But since almost as long, we've never actually used
that argument for anything - we just silently throw it away in
the macro. There's only one command (usbchargemode) that even
thinks it defines that argument.
We're never going to use this, let's just get rid of it.
BUG=none
BRANCH=none
CQ-DEPEND=CL:*279060
CQ-DEPEND=CL:*279158
CQ-DEPEND=CL:*279037
TEST=make buildall; tested on Cr50 hardware
Everything builds. Since we never used this arg anyway, there had
better not be any difference in the result.
Change-Id: Id3f71a53d02e3dc625cfcc12aa71ecb50e35eb9f
Signed-off-by: Bill Richardson <wfrichar@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/374163
Reviewed-by: Myles Watson <mylesgw@chromium.org>
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Diffstat (limited to 'common/charge_manager.c')
| -rw-r--r-- | common/charge_manager.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/common/charge_manager.c b/common/charge_manager.c index e7a7d997c0..a263277db6 100644 --- a/common/charge_manager.c +++ b/common/charge_manager.c @@ -938,8 +938,7 @@ static int command_charge_port_override(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(chgoverride, command_charge_port_override, "[port | -1 | -2]", - "Force charging from a given port (-1 = off, -2 = disable charging)", - NULL); + "Force charging from a given port (-1 = off, -2 = disable charging)"); #ifdef CONFIG_CHARGE_MANAGER_EXTERNAL_POWER_LIMIT static void charge_manager_set_external_power_limit(int current_lim, @@ -1010,8 +1009,7 @@ static int command_external_power_limit(int argc, char **argv) } DECLARE_CONSOLE_COMMAND(chglim, command_external_power_limit, "[max_current (mA)] [max_voltage (mV)]", - "Set max charger current / voltage", - NULL); + "Set max charger current / voltage"); #endif /* CONFIG_CHARGE_MANAGER_EXTERNAL_POWER_LIMIT */ #ifdef CONFIG_CMD_CHARGE_SUPPLIER_INFO @@ -1026,5 +1024,5 @@ static int charge_supplier_info(int argc, char **argv) return 0; } DECLARE_CONSOLE_COMMAND(chgsup, charge_supplier_info, - NULL, "print chg supplier info", NULL); + NULL, "print chg supplier info"); #endif |